Shegsdev/Banka

View on GitHub
server/controllers/usersController.js

Summary

Maintainability
C
1 day
Test Coverage

Function addStaff has 68 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  addStaff(req, res) {
    const {
      firstName, lastName, email, password, type,
    } = req.body;

Severity: Major
Found in server/controllers/usersController.js - About 2 hrs to fix

    Function getType has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      async getType(req, res) {
        const token = req.headers['x-access-token'];
        if (!token) {
          return res.status(401).json({
            status: 401,
    Severity: Minor
    Found in server/controllers/usersController.js - About 1 hr to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          try {
            const decoded = await jwt.verify(token, process.env.SECRET);
            const user = await User.findBy('email', decoded.username, res);
            if (!user.rows.length) {
              res.status(403).json({
      Severity: Major
      Found in server/controllers/usersController.js and 1 other location - About 3 hrs to fix
      server/middleware/verifyToken.js on lines 18..44

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 98.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

          User.findBy('id', parseInt(req.params.id, 10), res)
            .then((user) => {
              if (!user || !user.rows.length) {
                return res.status(403).json({
                  status: 403,
      Severity: Major
      Found in server/controllers/usersController.js and 3 other locations - About 3 hrs to fix
      server/controllers/accountsController.js on lines 82..90
      server/controllers/accountsController.js on lines 95..104
      server/controllers/accountsController.js on lines 437..449

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 95.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              data: {
                type: user.rows[0].type,
                isStaff: user.rows[0].is_staff,
                isAdmin: user.rows[0].is_admin,
              },
      Severity: Minor
      Found in server/controllers/usersController.js and 1 other location - About 55 mins to fix
      server/middleware/verifyToken.js on lines 27..31

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 53.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  if (err) {
                    return res.status(403).json({
                      status: 403,
                      error: `Some error occured - ${err}`,
                    });
      Severity: Minor
      Found in server/controllers/usersController.js and 1 other location - About 35 mins to fix
      server/controllers/auth/signupController.js on lines 67..72

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 46.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status