Showing 6 of 9 total issues
Function jova_do_something
has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring. Open
def jova_do_something(message):
if message and message.text:
# jova, I choose you!
if 'jova' in message.text.lower() or message.text.startswith('/'):
logging.info("[from {0}] [message ['{1}']]"
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function get_answer
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
def get_answer(message):
if '/' in message[0]:
return None
rx = r'jova canzone,?\s(.+)$'
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid too many return
statements within this function. Open
return result['path'], 'plain-text'
Function config
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def config():
# fallback api token path - only used if JOVABOT_API_TOKEN is not found
try:
webapp.config['TOKEN_PATH'] = os.environ['JOVABOT_TELEGRAM_TOKEN_PATH']
except (OSError, KeyError):
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function jova_paginebianche
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def jova_paginebianche(message):
rx = r'jova,?\s(?:cercami|trovami|cerca|trova|paginebianche)' \
'\s([\w\s]+)\s(?:a|ad|in)\s([\w\s]+)'
m = re.match(rx, message)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function channel_update
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def channel_update(secret):
logging.info('secret received is [{}]'.format(secret == webapp.config['CHANNEL_UPDATE_TOKEN']))
if secret == webapp.config['CHANNEL_UPDATE_TOKEN']:
raw_channel_update = request.get_json()
logging.debug(raw_channel_update)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"