Sign upLogin

SiLeBAT/FSK-Lab

View on GitHub
Star
de.bund.bfr.knime.js/src/js/app/app.modal.js

Summary

Maintainability
B
4 hrs
Test Coverage

Function _create has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    _create () {
        let O = this;
        _log( 'MODAL / _create' );

        O._id = O.opts.id || 'modal'+ $.now();
Severity: Minor
Found in de.bund.bfr.knime.js/src/js/app/app.modal.js - About 1 hr to fix

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            if ( $.isFunction( O.opts.on.hide ) ) {
                O.opts.on.hide.call( O, O, event );
            }
Severity: Minor
Found in de.bund.bfr.knime.js/src/js/app/app.modal.js and 1 other location - About 55 mins to fix
de.bund.bfr.knime.js/src/js/app/app.modal.js on lines 79..81

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 54.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            if ( $.isFunction( O.opts.on.show ) ) {
                O.opts.on.show.call( O, O, event );
            }
Severity: Minor
Found in de.bund.bfr.knime.js/src/js/app/app.modal.js and 1 other location - About 55 mins to fix
de.bund.bfr.knime.js/src/js/app/app.modal.js on lines 91..93

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 54.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    _createModalBody () {
        let O = this;
        _log( 'MODAL / _createBody' );

        O._$modalBody = $( '<div class="modal-body"></div>' )
Severity: Major
Found in de.bund.bfr.knime.js/src/js/app/app.modal.js and 2 other locations - About 55 mins to fix
de.bund.bfr.knime.js/src/js/app/app.editable.mt.details.js on lines 105..111
de.bund.bfr.knime.js/src/js/app/app.mt.details.js on lines 104..110

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 53.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        if ( $.isFunction( O.opts.on.afterInit ) ) {
            O.opts.on.afterInit.call( O );
        }
Severity: Minor
Found in de.bund.bfr.knime.js/src/js/app/app.modal.js and 1 other location - About 50 mins to fix
de.bund.bfr.knime.js/src/js/app/app.landingpage.js on lines 41..43

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 52.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status