Sign upLogin

Sieabah/feathersjs-couchbase

View on GitHub
Star
lib/service/couchbase.service.js

Summary

Maintainability
A
2 hrs
Test Coverage

File couchbase.service.js has 251 lines of code (exceeds 250 allowed). Consider refactoring.
Confirmed

'use strict';

const Promise = require('bluebird');
const { BadRequest, NotFound, NotImplemented } = require('@feathersjs/errors');
const { keyNotFound } = require('couchbase').errors;
Severity: Minor
Found in lib/service/couchbase.service.js - About 2 hrs to fix

    Function constructor has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Invalid

      constructor (opts) {
    this.opts = opts || {};

    if (this.opts.couchbase == null) {
      this.opts.couchbase = require('couchbase');
    Severity: Minor
    Found in lib/service/couchbase.service.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _find has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Wontfix

      _find (query, paginate, consistency = null) {
    const { couchbase } = this.opts;
    const QB = (new QueryBuilder(this.opts.bucket));
    const { query: queryStr, values } = QB.interpret(query);
    Severity: Minor
    Found in lib/service/couchbase.service.js - About 1 hr to fix

      Function patch has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Wontfix

        patch (id, data, params) {
    return new Promise((resolve) => {
      if (id == null && (params || {}).query && !this._isMultiAllowed('patch')) {
        throw new BadRequest('Multi-access is not enabled for this service method');
      } else if (id == null && this._isMultiAllowed('patch')) {
      Severity: Minor
      Found in lib/service/couchbase.service.js - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Invalid

              if (id == null && (params || {}).query && !this._isMultiAllowed('remove')) {
        throw new BadRequest('Multi-access is not enabled for this service method');
      } else if (id == null && this._isMultiAllowed('remove')) {
        throw new NotImplemented('Service adapter does not support multi-remove at current time');
      }
        Severity: Major
        Found in lib/service/couchbase.service.js and 1 other location - About 2 hrs to fix
        lib/service/couchbase.service.js on lines 340..344

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 76.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Invalid

              if (id == null && (params || {}).query && !this._isMultiAllowed('patch')) {
        throw new BadRequest('Multi-access is not enabled for this service method');
      } else if (id == null && this._isMultiAllowed('patch')) {
        throw new NotImplemented('Service adapter does not support multi-patch at current time');
      }
        Severity: Major
        Found in lib/service/couchbase.service.js and 1 other location - About 2 hrs to fix
        lib/service/couchbase.service.js on lines 376..380

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 76.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status