SkouRene/HL-phpclient

View on GitHub

Showing 4 of 8 total issues

Method makeCall has 48 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function makeCall($requestType, $url, $postFields, $file, $signature, $date)
    {
        $headers = array(
            "authorization: Basic " . $signature . "",
            "x-request-timestamp: " . $date . "",
Severity: Minor
Found in src/HL-phpclient/HLCurlHandler.php - About 1 hr to fix

    Method makeCall has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        protected function makeCall($requestType, $url, $postFields, $file, $signature, $date)
    Severity: Minor
    Found in src/HL-phpclient/HLCurlHandler.php - About 45 mins to fix

      Function makeCall has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function makeCall($requestType, $url, $postFields, $file, $signature, $date)
          {
              $headers = array(
                  "authorization: Basic " . $signature . "",
                  "x-request-timestamp: " . $date . "",
      Severity: Minor
      Found in src/HL-phpclient/HLCurlHandler.php - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method update has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public function update($listId, $webhookId, $url, array $settings=array(), $contactEmail = '')
      Severity: Minor
      Found in src/HL-phpclient/HLWebhooks.php - About 35 mins to fix
        Severity
        Category
        Status
        Source
        Language