SmashKs/OneShoot

View on GitHub

Showing 29 of 166 total issues

Method peelResponseOptions has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

    response: KsResponse<D>,
    isShowLoading: Boolean = true,
    isShowError: Boolean = true,
    isHideLoading: Boolean = true,
    errorBlock: ((String) -> Unit)? = null,
Severity: Major
Found in presentation/src/main/java/smash/ks/com/oneshoot/ext/aac/Extensions.kt - About 50 mins to fix

    Avoid too many return statements within this method.
    Open

                        return false;

      Avoid too many return statements within this method.
      Open

              if (tags != casted.tags) return false
      Severity: Major
      Found in domain/src/main/java/smash/ks/com/domain/parameters/PhotoParam.kt - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                return true
        Severity: Major
        Found in domain/src/main/java/smash/ks/com/domain/parameters/PhotoParam.kt - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                  if (uploadDate != casted.uploadDate) return false
          Severity: Major
          Found in domain/src/main/java/smash/ks/com/domain/parameters/PhotoParam.kt - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                    if (title != casted.title) return false
            Severity: Major
            Found in domain/src/main/java/smash/ks/com/domain/parameters/PhotoParam.kt - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                      if (author != casted.author) return false
              Severity: Major
              Found in domain/src/main/java/smash/ks/com/domain/parameters/PhotoParam.kt - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                        return true;

                  Method uploadImage has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
                  Open

                      override fun uploadImage(params: Parameterable) = completable { emitter ->
                          ref.child(V2_CHILD_PROPERTIES).child(V2_CHILD_ANONYMOUS).apply {
                              val key = push().key
                  
                              if (key.isNull()) {
                  Severity: Minor
                  Found in data/src/main/java/smash/ks/com/data/remote/v2/KsFirebaseImpl.kt - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Severity
                  Category
                  Status
                  Source
                  Language