Smile-SA/elasticsuite

View on GitHub

Showing 620 of 1,375 total issues

Function drawGrid has 44 lines of code (exceeds 40 allowed). Consider refactoring.
Open

        drawGrid(chartArea) {
            const me = this;
            const grid = me.options.grid;
            const ctx = me.ctx;
            const items = me._gridLineItems || (me._gridLineItems = me._computeGridLineItems(chartArea));
Severity: Minor
Found in src/module-elasticsuite-core/view/adminhtml/web/js/lib/chart.js - About 1 hr to fix

    Function lttbDecimation has 44 lines of code (exceeds 40 allowed). Consider refactoring.
    Open

        function lttbDecimation(data, start, count, availableWidth, options) {
            const samples = options.samples || availableWidth;
            if (samples >= count) {
                return data.slice(start, start + count);
            }
    Severity: Minor
    Found in src/module-elasticsuite-core/view/adminhtml/web/js/lib/chart.js - About 1 hr to fix

      Method __construct has 9 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              QueryInterface $searchQuery,
              FulltextCollectionFactory $productCollectionFactory,
              ItemDataFactory $previewItemFactory,
              QueryFactory $queryFactory,
              QueryBuilder $queryBuilder,
      Severity: Major
      Found in src/module-elasticsuite-catalog/Model/Search/Preview.php - About 1 hr to fix

        Method __construct has 9 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                \Magento\Framework\Model\Context $context,
                \Magento\Framework\Registry $registry,
                \Smile\ElasticsuiteCatalogRule\Model\RuleFactory  $ruleFactory,
                \Magento\Framework\Stdlib\DateTime\Filter\Date $dateFilter,
                \Magento\Framework\Serialize\SerializerInterface $serializer,
        Severity: Major
        Found in src/module-elasticsuite-catalog-optimizer/Model/Optimizer.php - About 1 hr to fix

          Method __construct has 9 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  Context $context,
                  Registry $registry,
                  FormFactory $formFactory,
                  Factory $configFactory,
                  Structure $configStructure,

            Method __construct has 9 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                    RequestFactory $requestFactory,
                    DimensionFactory $dimensionFactory,
                    QueryBuilder $queryBuilder,
                    SortOrderBuilder $sortOrderBuilder,
                    AggregationBuilder $aggregationBuilder,
            Severity: Major
            Found in src/module-elasticsuite-core/Search/Request/Builder.php - About 1 hr to fix

              Method __construct has 9 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                      $queryText,
                      array $fields,
                      $minimumShouldMatch = self::DEFAULT_MINIMUM_SHOULD_MATCH,
                      $tieBreaker = self::DEFAULT_TIE_BREAKER,
                      $name = null,
              Severity: Major
              Found in src/module-elasticsuite-core/Search/Request/Query/MultiMatch.php - About 1 hr to fix

                Method __construct has 9 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                        $name,
                        $primaryFieldName,
                        $requestFieldName,
                        \Magento\Search\Model\ResourceModel\Query\CollectionFactory $collectionFactory,
                        \Magento\Framework\Locale\FormatInterface $localeFormat,

                  Method __construct has 9 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                          CategoryInterface $category,
                          FulltextCollectionFactory $productCollectionFactory,
                          ItemDataFactory $previewItemFactory,
                          QueryFactory $queryFactory,
                          ContextInterface $searchContext,
                  Severity: Major
                  Found in src/module-elasticsuite-virtual-category/Model/Preview.php - About 1 hr to fix

                    Function _getYAxisLabelAlignment has 43 lines of code (exceeds 40 allowed). Consider refactoring.
                    Open

                            _getYAxisLabelAlignment(tl) {
                                const me = this;
                                const {position, ticks: {crossAlign, mirror, padding}} = me.options;
                                const labelSizes = me._getLabelSizes();
                                const tickAndPadding = tl + padding;
                    Severity: Minor
                    Found in src/module-elasticsuite-core/view/adminhtml/web/js/lib/chart.js - About 1 hr to fix

                      Function _mouseDown has 43 lines of code (exceeds 40 allowed). Consider refactoring.
                      Open

                              _mouseDown: function( event ) {
                      
                                  // don't let more than one widget handle mouseStart
                                  if ( mouseHandled ) {
                                      return;
                      Severity: Minor
                      Found in src/module-elasticsuite-catalog/view/frontend/web/js/mouse.js - About 1 hr to fix

                        Function fastPathSegment has 43 lines of code (exceeds 40 allowed). Consider refactoring.
                        Open

                            function fastPathSegment(ctx, line, segment, params) {
                                const points = line.points;
                                const {count, start, ilen} = pathVars(points, segment, params);
                                const {move = true, reverse} = params || {};
                                let avgX = 0;
                        Severity: Minor
                        Found in src/module-elasticsuite-core/view/adminhtml/web/js/lib/chart.js - About 1 hr to fix

                          Function update has 43 lines of code (exceeds 40 allowed). Consider refactoring.
                          Open

                                  update(changed, replay) {
                                      const me = this;
                                      const options = me.options.setContext(me.getContext());
                                      const active = me._active;
                                      let properties;
                          Severity: Minor
                          Found in src/module-elasticsuite-core/view/adminhtml/web/js/lib/chart.js - About 1 hr to fix

                            Function update has 43 lines of code (exceeds 40 allowed). Consider refactoring.
                            Open

                                    update(mode) {
                                        const me = this;
                                        const config = me.config;
                                        config.update();
                                        me._options = config.createResolver(config.chartOptionScopes(), me.getContext());
                            Severity: Minor
                            Found in src/module-elasticsuite-core/view/adminhtml/web/js/lib/chart.js - About 1 hr to fix

                              Method checkUpdateNeeded has 43 lines of code (exceeds 40 allowed). Consider refactoring.
                              Open

                                  private function checkUpdateNeeded($subject)
                                  {
                                      $updateMapping = $cleanCache = $invalidateIndex = false;
                              
                                      if ($this->saveIsNew === true) {

                                Method getSuggestions has 43 lines of code (exceeds 40 allowed). Consider refactoring.
                                Open

                                    private function getSuggestions(string $queryText, int $maxSize = self::MAX_COUNT)
                                    {
                                        $suggestions     = [];
                                        $containerConfig = $this->getRequestContainerConfiguration(
                                            $this->storeManager->getStore()->getId(),
                                Severity: Minor
                                Found in src/module-elasticsuite-core/Model/DataProvider/Suggestions.php - About 1 hr to fix

                                  Method parseAnalyzers has 43 lines of code (exceeds 40 allowed). Consider refactoring.
                                  Open

                                      private function parseAnalyzers(
                                          \DOMXPath $xpath,
                                          array $availableCharFilters,
                                          array $availableFilters,
                                          $language = self::LANGUAGE_DEFAULT,
                                  Severity: Minor
                                  Found in src/module-elasticsuite-core/Index/Analysis/Config/Converter.php - About 1 hr to fix

                                    Method getSpanQuery has 43 lines of code (exceeds 40 allowed). Consider refactoring.
                                    Open

                                        private function getSpanQuery(ContainerConfigurationInterface $containerConfig, $queryText, $boost)
                                        {
                                            $query = null;
                                            $terms = explode(' ', $queryText);
                                    
                                    

                                      Function getSearchQueryIdentities has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                                      Open

                                          private function getSearchQueryIdentities()
                                          {
                                              $identities = [];
                                              $queryIds   = [];
                                              $origData   = $this->optimizer->getOrigData();

                                      Cognitive Complexity

                                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                      A method's cognitive complexity is based on a few simple rules:

                                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                      • Code is considered more complex for each "break in the linear flow of the code"
                                      • Code is considered more complex when "flow breaking structures are nested"

                                      Further reading

                                      Function apply has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                                      Open

                                          public function apply(\Magento\Framework\App\RequestInterface $request)
                                          {
                                              /**
                                               * Filter must be string: $fromPrice-$toPrice
                                               */

                                      Cognitive Complexity

                                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                      A method's cognitive complexity is based on a few simple rules:

                                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                      • Code is considered more complex for each "break in the linear flow of the code"
                                      • Code is considered more complex when "flow breaking structures are nested"

                                      Further reading

                                      Severity
                                      Category
                                      Status
                                      Source
                                      Language