Smile-SA/elasticsuite

View on GitHub
src/module-elasticsuite-indices/view/adminhtml/web/js/jquery.json-viewer.js

Summary

Maintainability
B
4 hrs
Test Coverage

Function 'json2html' has a complexity of 18.
Open

  function json2html(json, options) {

Limit Cyclomatic Complexity (complexity)

Cyclomatic complexity measures the number of linearly independent paths through a program's source code. This rule allows setting a cyclomatic complexity threshold.

function a(x) {
    if (true) {
        return x; // 1st path
    } else if (false) {
        return x+1; // 2nd path
    } else {
        return 4; // 3rd path
    }
}

Rule Details

This rule is aimed at reducing code complexity by capping the amount of cyclomatic complexity allowed in a program. As such, it will warn when the cyclomatic complexity crosses the configured threshold (default is 20).

Examples of incorrect code for a maximum of 2:

/*eslint complexity: ["error", 2]*/

function a(x) {
    if (true) {
        return x;
    } else if (false) {
        return x+1;
    } else {
        return 4; // 3rd path
    }
}

Examples of correct code for a maximum of 2:

/*eslint complexity: ["error", 2]*/

function a(x) {
    if (true) {
        return x;
    } else {
        return 4;
    }
}

Options

Optionally, you may specify a max object property:

"complexity": ["error", 2]

is equivalent to

"complexity": ["error", { "max": 2 }]

Deprecated: the object property maximum is deprecated. Please use the property max instead.

When Not To Use It

If you can't determine an appropriate complexity limit for your code, then it's best to disable this rule.

Further Reading

Related Rules

  • [max-depth](max-depth.md)
  • [max-len](max-len.md)
  • [max-nested-callbacks](max-nested-callbacks.md)
  • [max-params](max-params.md)
  • [max-statements](max-statements.md) Source: http://eslint.org/docs/rules/

Function 'json2html' has too many statements (39). Maximum allowed is 30.
Open

  function json2html(json, options) {

enforce a maximum number of statements allowed in function blocks (max-statements)

The max-statements rule allows you to specify the maximum number of statements allowed in a function.

function foo() {
  var bar = 1; // one statement
  var baz = 2; // two statements
  var qux = 3; // three statements
}

Rule Details

This rule enforces a maximum number of statements allowed in function blocks.

Options

This rule has a number or object option:

  • "max" (default 10) enforces a maximum number of statements allows in function blocks

Deprecated: The object property maximum is deprecated; please use the object property max instead.

This rule has an object option:

  • "ignoreTopLevelFunctions": true ignores top-level functions

max

Examples of incorrect code for this rule with the default { "max": 10 } option:

/*eslint max-statements: ["error", 10]*/
/*eslint-env es6*/

function foo() {
  var foo1 = 1;
  var foo2 = 2;
  var foo3 = 3;
  var foo4 = 4;
  var foo5 = 5;
  var foo6 = 6;
  var foo7 = 7;
  var foo8 = 8;
  var foo9 = 9;
  var foo10 = 10;

  var foo11 = 11; // Too many.
}

let foo = () => {
  var foo1 = 1;
  var foo2 = 2;
  var foo3 = 3;
  var foo4 = 4;
  var foo5 = 5;
  var foo6 = 6;
  var foo7 = 7;
  var foo8 = 8;
  var foo9 = 9;
  var foo10 = 10;

  var foo11 = 11; // Too many.
};

Examples of correct code for this rule with the default { "max": 10 } option:

/*eslint max-statements: ["error", 10]*/
/*eslint-env es6*/

function foo() {
  var foo1 = 1;
  var foo2 = 2;
  var foo3 = 3;
  var foo4 = 4;
  var foo5 = 5;
  var foo6 = 6;
  var foo7 = 7;
  var foo8 = 8;
  var foo9 = 9;
  var foo10 = 10;
  return function () {

    // The number of statements in the inner function does not count toward the
    // statement maximum.

    return 42;
  };
}

let foo = () => {
  var foo1 = 1;
  var foo2 = 2;
  var foo3 = 3;
  var foo4 = 4;
  var foo5 = 5;
  var foo6 = 6;
  var foo7 = 7;
  var foo8 = 8;
  var foo9 = 9;
  var foo10 = 10;
  return function () {

    // The number of statements in the inner function does not count toward the
    // statement maximum.

    return 42;
  };
}

ignoreTopLevelFunctions

Examples of additional correct code for this rule with the { "max": 10 }, { "ignoreTopLevelFunctions": true } options:

/*eslint max-statements: ["error", 10, { "ignoreTopLevelFunctions": true }]*/

function foo() {
  var foo1 = 1;
  var foo2 = 2;
  var foo3 = 3;
  var foo4 = 4;
  var foo5 = 5;
  var foo6 = 6;
  var foo7 = 7;
  var foo8 = 8;
  var foo9 = 9;
  var foo10 = 10;
  var foo11 = 11;
}

Related Rules

  • [complexity](complexity.md)
  • [max-depth](max-depth.md)
  • [max-len](max-len.md)
  • [max-nested-callbacks](max-nested-callbacks.md)
  • [max-params](max-params.md) Source: http://eslint.org/docs/rules/

Function json2html has 65 lines of code (exceeds 40 allowed). Consider refactoring.
Open

  function json2html(json, options) {
    var html = '';
    if (typeof json === 'string') {
      // Escape tags and quotes
      json = json

    Avoid deeply nested control flow statements.
    Open

            for (var key in json) {
              if (Object.prototype.hasOwnProperty.call(json, key)) {
                html += '<li>';
                var keyRepr = options.withQuotes ?
                  '<span class="json-string">"' + key + '"</span>' : key;

      Avoid deeply nested control flow statements.
      Open

                if (isCollapsable(json[i])) {
                  html += '<a href class="json-toggle"></a>';
                }

        Avoid deeply nested control flow statements.
        Open

                  if (i < json.length - 1) {
                    html += ',';
                  }

          Expected '===' and instead saw '=='.
          Open

                if (options.collapsed == true) {

          Require === and !== (eqeqeq)

          It is considered good practice to use the type-safe equality operators === and !== instead of their regular counterparts == and !=.

          The reason for this is that == and != do type coercion which follows the rather obscure Abstract Equality Comparison Algorithm. For instance, the following statements are all considered true:

          • [] == false
          • [] == ![]
          • 3 == "03"

          If one of those occurs in an innocent-looking statement such as a == b the actual problem is very difficult to spot.

          Rule Details

          This rule is aimed at eliminating the type-unsafe equality operators.

          Examples of incorrect code for this rule:

          /*eslint eqeqeq: "error"*/
          
          if (x == 42) { }
          
          if ("" == text) { }
          
          if (obj.getStuff() != undefined) { }

          The --fix option on the command line automatically fixes some problems reported by this rule. A problem is only fixed if one of the operands is a typeof expression, or if both operands are literals with the same type.

          Options

          always

          The "always" option (default) enforces the use of === and !== in every situation (except when you opt-in to more specific handling of null [see below]).

          Examples of incorrect code for the "always" option:

          /*eslint eqeqeq: ["error", "always"]*/
          
          a == b
          foo == true
          bananas != 1
          value == undefined
          typeof foo == 'undefined'
          'hello' != 'world'
          0 == 0
          true == true
          foo == null

          Examples of correct code for the "always" option:

          /*eslint eqeqeq: ["error", "always"]*/
          
          a === b
          foo === true
          bananas !== 1
          value === undefined
          typeof foo === 'undefined'
          'hello' !== 'world'
          0 === 0
          true === true
          foo === null

          This rule optionally takes a second argument, which should be an object with the following supported properties:

          • "null": Customize how this rule treats null literals. Possible values:
            • always (default) - Always use === or !==.
            • never - Never use === or !== with null.
            • ignore - Do not apply this rule to null.

          smart

          The "smart" option enforces the use of === and !== except for these cases:

          • Comparing two literal values
          • Evaluating the value of typeof
          • Comparing against null

          Examples of incorrect code for the "smart" option:

          /*eslint eqeqeq: ["error", "smart"]*/
          
          // comparing two variables requires ===
          a == b
          
          // only one side is a literal
          foo == true
          bananas != 1
          
          // comparing to undefined requires ===
          value == undefined

          Examples of correct code for the "smart" option:

          /*eslint eqeqeq: ["error", "smart"]*/
          
          typeof foo == 'undefined'
          'hello' != 'world'
          0 == 0
          true == true
          foo == null

          allow-null

          Deprecated: Instead of using this option use "always" and pass a "null" option property with value "ignore". This will tell eslint to always enforce strict equality except when comparing with the null literal.

          ["error", "always", {"null": "ignore"}]

          When Not To Use It

          If you don't want to enforce a style for using equality operators, then it's safe to disable this rule. Source: http://eslint.org/docs/rules/

          Move the invocation into the parens that contain the function.
          Open

          (function($) {

          Require IIFEs to be Wrapped (wrap-iife)

          You can immediately invoke function expressions, but not function declarations. A common technique to create an immediately-invoked function expression (IIFE) is to wrap a function declaration in parentheses. The opening parentheses causes the contained function to be parsed as an expression, rather than a declaration.

          // function expression could be unwrapped
          var x = function () { return { y: 1 };}();
          
          // function declaration must be wrapped
          function () { /* side effects */ }(); // SyntaxError

          Rule Details

          This rule requires all immediately-invoked function expressions to be wrapped in parentheses.

          Options

          This rule has two options, a string option and an object option.

          String option:

          • "outside" enforces always wrapping the call expression. The default is "outside".
          • "inside" enforces always wrapping the function expression.
          • "any" enforces always wrapping, but allows either style.

          Object option:

          • "functionPrototypeMethods": true additionally enforces wrapping function expressions invoked using .call and .apply. The default is false.

          outside

          Examples of incorrect code for the default "outside" option:

          /*eslint wrap-iife: ["error", "outside"]*/
          
          var x = function () { return { y: 1 };}(); // unwrapped
          var x = (function () { return { y: 1 };})(); // wrapped function expression

          Examples of correct code for the default "outside" option:

          /*eslint wrap-iife: ["error", "outside"]*/
          
          var x = (function () { return { y: 1 };}()); // wrapped call expression

          inside

          Examples of incorrect code for the "inside" option:

          /*eslint wrap-iife: ["error", "inside"]*/
          
          var x = function () { return { y: 1 };}(); // unwrapped
          var x = (function () { return { y: 1 };}()); // wrapped call expression

          Examples of correct code for the "inside" option:

          /*eslint wrap-iife: ["error", "inside"]*/
          
          var x = (function () { return { y: 1 };})(); // wrapped function expression

          any

          Examples of incorrect code for the "any" option:

          /*eslint wrap-iife: ["error", "any"]*/
          
          var x = function () { return { y: 1 };}(); // unwrapped

          Examples of correct code for the "any" option:

          /*eslint wrap-iife: ["error", "any"]*/
          
          var x = (function () { return { y: 1 };}()); // wrapped call expression
          var x = (function () { return { y: 1 };})(); // wrapped function expression

          functionPrototypeMethods

          Examples of incorrect code for this rule with the "inside", { "functionPrototypeMethods": true } options:

          /* eslint wrap-iife: [2, "inside", { functionPrototypeMethods: true }] */
          
          var x = function(){ foo(); }()
          var x = (function(){ foo(); }())
          var x = function(){ foo(); }.call(bar)
          var x = (function(){ foo(); }.call(bar))

          Examples of correct code for this rule with the "inside", { "functionPrototypeMethods": true } options:

          /* eslint wrap-iife: [2, "inside", { functionPrototypeMethods: true }] */
          
          var x = (function(){ foo(); })()
          var x = (function(){ foo(); }).call(bar)

          Source: http://eslint.org/docs/rules/

          There are no issues that match your filters.

          Category
          Status