Sign upLogin

SpamExperts/whmcs-addon

View on GitHub
Star

Showing 25 of 72 total issues

Avoid too many return statements within this method.
Open

        return $res;
Severity: Major
Found in modules/servers/kwspamexperts/kwspamexperts.php - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

        return "success";
    Severity: Major
    Found in modules/servers/kwspamexperts/kwspamexperts.php - About 30 mins to fix

      Function __construct has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          public function __construct($settings = null)
    {
        //load settings if user specified some options
        if($settings)
        {
      Severity: Minor
      Found in modules/addons/spamexperts/core/logger/FileLogger.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function kwspamexperts_CreateAccount has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

      function kwspamexperts_CreateAccount($params)
{
    $api        = new kwspamexperts_api($params);
    $domain     = !empty($params["customfields"]["Domain"])  ? $params["customfields"]["Domain"] : $params['domain'];
    $password   = !empty($params['password'])                ? $params["password"]               : createServerPassword();
      Severity: Minor
      Found in modules/servers/kwspamexperts/kwspamexperts.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function updateProductsConfig has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          function updateProductsConfig($c)
    {
        $array = unserialize($c);

        if (!isset($array['disable_manage_routes'])) {
      Severity: Minor
      Found in modules/addons/spamexperts/core/functions.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language