Sign upLogin

SpeciesFileGroup/taxonworks

View on GitHub
Star
app/assets/javascripts/views/tasks/nomenclature/browse.js

Summary

Maintainability
D
2 days
Test Coverage

Function init has 241 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  init: function () {
    let softValidations

    function fillSoftValidation() {
      if (!softValidations) {
Severity: Major
Found in app/assets/javascripts/views/tasks/nomenclature/browse.js - About 1 day to fix

    Function init has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
    Open

      init: function () {
    let softValidations

    function fillSoftValidation() {
      if (!softValidations) {
    Severity: Minor
    Found in app/assets/javascripts/views/tasks/nomenclature/browse.js - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File browse.js has 255 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    var TW = TW || {}
TW.views = TW.views || {}
TW.views.tasks = TW.views.tasks || {}
TW.views.tasks.nomenclature = TW.views.tasks.nomenclature || {}
TW.views.tasks.nomenclature.browse = TW.views.tasks.nomenclature.browse || {}
    Severity: Minor
    Found in app/assets/javascripts/views/tasks/nomenclature/browse.js - About 2 hrs to fix

      Function fillSoftValidation has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          function fillSoftValidation() {
      if (!softValidations) {
        const validationElements = [
          ...document.querySelectorAll(
            '[data-icon="attention"][data-global-id]'
      Severity: Minor
      Found in app/assets/javascripts/views/tasks/nomenclature/browse.js - About 1 hr to fix

        Function createValidationModal has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            function createValidationModal(validationList) {
      const list = validationList
        .map((item) => '<li class="list">' + item.message + '</li>')
        .join('')
      const template = document.createElement('template')
        Severity: Minor
        Found in app/assets/javascripts/views/tasks/nomenclature/browse.js - About 1 hr to fix

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                TW.workbench.keyboard.createShortcut(
        platformKey + '+m',
        'New type specimen',
        'Browse nomenclature',
        () => {
          Severity: Major
          Found in app/assets/javascripts/views/tasks/nomenclature/browse.js and 2 other locations - About 50 mins to fix
          app/assets/javascripts/views/tasks/nomenclature/browse.js on lines 105..115
          app/assets/javascripts/views/tasks/nomenclature/browse.js on lines 117..124

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 52.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                TW.workbench.keyboard.createShortcut(
        platformKey + '+e',
        'Comprehensive specimen digitization',
        'Browse nomenclature',
        () => {
          Severity: Major
          Found in app/assets/javascripts/views/tasks/nomenclature/browse.js and 2 other locations - About 50 mins to fix
          app/assets/javascripts/views/tasks/nomenclature/browse.js on lines 93..103
          app/assets/javascripts/views/tasks/nomenclature/browse.js on lines 117..124

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 52.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                TW.workbench.keyboard.createShortcut(
        platformKey + '+o',
        'Browse OTU',
        'Browse nomenclature',
        () => {
          Severity: Major
          Found in app/assets/javascripts/views/tasks/nomenclature/browse.js and 2 other locations - About 50 mins to fix
          app/assets/javascripts/views/tasks/nomenclature/browse.js on lines 93..103
          app/assets/javascripts/views/tasks/nomenclature/browse.js on lines 105..115

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 52.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status