Sign upLogin

SpeciesFileGroup/taxonworks

View on GitHub
Star

Showing 927 of 12,579 total issues

Method create has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
Open

    def create
      @create_attempted = true

      if ready_to_create?
        # TODO: DRY
Severity: Minor
Found in lib/batch_load/import.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method descriptors_hash_initiate has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
Open

  def descriptors_hash_initiate
    h = {}

    descriptors_with_keywords.each do |d|
      h[d.id] = {}
Severity: Minor
Found in lib/tools/interactive_key.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method significant_digits has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
Open

    def self.significant_digits(number_string)
      # is there a decimal point?
      intg = ''
      decimal_point_zeros = ''
      mantissa = ''
Severity: Minor
Found in lib/utilities/geo.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method has too many lines. [44/25]
Open

      def autocomplete
        return [] if query_string.blank? || project_id.empty?

        queries = [
          [ autocomplete_exact_id, false ],
Severity: Minor
Found in lib/queries/person/autocomplete.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Class Result has 31 methods (exceeds 20 allowed). Consider refactoring.
Open

  class Result
    SMALL_WIDTH = 100
    LARGE_WIDTH = 400

    TEXT_MAP = {
Severity: Minor
Found in lib/vendor/sqed_to_taxonworks.rb - About 3 hrs to fix

    Method has too many lines. [43/25]
    Open

        def citations_with_names
      return @citations_with_names if !@citations_with_names.nil?

      d = Hash.new do |hash, key|
        hash[key] = []
    Severity: Minor
    Found in lib/catalog/nomenclature/entry.rb by rubocop

    This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

    Method has too many lines. [43/25]
    Open

      def self.date_sql_from_params(params)
    st_date, end_date = params['st_datepicker'], params['en_datepicker']
    # processing start date data
    st_year, st_month, st_day = params['start_date_year'], params['start_date_month'], params['start_date_day']
    unless st_date.blank?
    Severity: Minor
    Found in lib/utilities/dates.rb by rubocop

    This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

    Method date_sql_from_params has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
    Open

      def self.date_sql_from_params(params)
    st_date, end_date = params['st_datepicker'], params['en_datepicker']
    # processing start date data
    st_year, st_month, st_day = params['start_date_year'], params['start_date_month'], params['start_date_day']
    unless st_date.blank?
    Severity: Minor
    Found in lib/utilities/dates.rb - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method conform_significant has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
    Open

        def self.conform_significant(number, sig_digits)
      input = significant_digits(number.to_s)
      input_string = input[0]
      intg = input[2]
      decimal_point = input[3]
    Severity: Minor
    Found in lib/utilities/geo.rb - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method to_s_verbose has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
    Open

      def to_s_verbose
    d = data
    str = ''

    d.keys.sort{|a,b| (a || 'zzz') <=> (b || 'zzz')}.each do |c|
    Severity: Minor
    Found in lib/catalog/distribution/entry.rb - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File filter.rb has 320 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    module Queries
  module CollectingEvent
    class Filter < Query::Filter

      # Params exists for all CollectingEvent attributes except these.
    Severity: Minor
    Found in lib/queries/collecting_event/filter.rb - About 3 hrs to fix

      Class Filter has 30 methods (exceeds 20 allowed). Consider refactoring.
      Open

          class Filter < Query::Filter

      # Params exists for all CollectingEvent attributes except these.
      # geographic_area_id is excluded because we handle it specially in conjunction with `geographic_area_mode``
      # Definition must preceed include.
      Severity: Minor
      Found in lib/queries/collecting_event/filter.rb - About 3 hrs to fix

        Method has too many lines. [42/25]
        Open

          def becomes_combination
    a, original_relationships, c = nil, nil, nil

    if b = convertable_to_combination?
      a, original_relationships = b
        Severity: Minor
        Found in app/models/protonym/becomes.rb by rubocop

        This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

        Method has too many lines. [42/25]
        Open

            def sv_potential_species_homonyms
      if persisted? && is_species_rank? && is_available?
        if TaxonNameRelationship.where_subject_is_taxon_name(self).homonym_or_suppressed.empty?
          if self.id == self.lowest_rank_coordinated_taxon.id
            name1 = self.cached_primary_homonym ? self.cached_primary_homonym : nil
        Severity: Minor
        Found in app/models/protonym/soft_validation_extensions.rb by rubocop

        This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

        Method has too many lines. [42/25]
        Open

          def save_selected
    next_id = next_collecting_event_id
    selected = params[:selected]
    if selected.blank?
      message = 'Nothing to save.'
        Severity: Minor
        Found in app/controllers/tasks/collecting_events/parse/stepwise/dates_controller.rb by rubocop

        This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

        Method generate has 90 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def self.generate(otu, project_members, reference_csv = nil)
     name_total = 0
    ::CSV.generate(col_sep: "\t") do |csv|
      csv << %w{
        ID
        Severity: Major
        Found in lib/export/coldp/files/name.rb - About 3 hrs to fix

          Method generate has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
          Open

            def self.generate(otus, project_members, reference_csv = nil)
    ::CSV.generate(col_sep: "\t") do |csv|

      csv << %w{taxonID nameID status remarks referenceID modified modifiedBy}
          Severity: Minor
          Found in lib/export/coldp/files/synonym.rb - About 3 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Class SourcesController has 29 methods (exceeds 20 allowed). Consider refactoring.
          Open

          class SourcesController < ApplicationController
  include DataControllerConfiguration::SharedDataControllerConfiguration

  before_action :set_source, only: [:show, :edit, :update, :destroy, :clone, :api_show]
  after_action -> { set_pagination_headers(:sources) }, only: [:index, :api_index ], if: :json_request?
          Severity: Minor
          Found in app/controllers/sources_controller.rb - About 3 hrs to fix

            Method build_collecting_events has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
            Open

                def build_collecting_events
      # DRMFieldNumbers DRMFN
      namespace_drm_field_numbers = Namespace.find_by(name: 'DRMFieldNumbers')

      @total_data_lines = 0
            Severity: Minor
            Found in lib/batch_load/import/collecting_events/castor_interpreter.rb - About 3 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method included_annotator_facets has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
            Open

                def self.included_annotator_facets
      f = [
        ::Queries::Concerns::Users
      ]
            Severity: Minor
            Found in lib/queries/query/filter.rb - About 3 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Severity
            Category
            Status
            Source
            Language