SpeciesFileGroup/taxonworks

View on GitHub

Showing 732 of 12,571 total issues

Function handleEvents has 127 lines of code (exceeds 25 allowed). Consider refactoring.
Open

FilterHub.prototype.handleEvents = function (that) {
  const elements = [...document.querySelectorAll('#task_carrousel')]

  that.arrayTasks = elements.map(
    (element) =>
Severity: Major
Found in app/assets/javascripts/views/hub/filterHub.js - About 5 hrs to fix

    File dwc_extensions.rb has 371 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    module FieldOccurrence::DwcExtensions
    
      extend ActiveSupport::Concern
    
      # include FieldOccurrence::DwcExtensions::TaxonworksExtensions
    Severity: Minor
    Found in app/models/field_occurrence/dwc_extensions.rb - About 4 hrs to fix

      Function makeInitialState has 120 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function makeInitialState() {
        return {
          loadState: {
            assertedDistribution: false,
            biologicalAssociations: true,
      Severity: Major
      Found in app/javascript/vue/tasks/otu/browse/store/store.js - About 4 hrs to fix

        Function init has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
        Open

          init: function () {
            let softValidations
        
            function fillSoftValidation() {
              if (!softValidations) {
        Severity: Minor
        Found in app/assets/javascripts/views/tasks/nomenclature/browse.js - About 4 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method add_original_combination has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
        Open

          def self.add_original_combination(t, csv, origin_citation, name_remarks_vocab_id, project_members)
            e = t.original_combination_elements
        
            infraspecific_element = t.original_combination_infraspecific_element(e, remove_sic: true)
        
        
        Severity: Minor
        Found in lib/export/coldp/files/name.rb - About 4 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Class Data has 35 methods (exceeds 20 allowed). Consider refactoring.
        Open

          class Data
        
            attr_accessor :data
        
            attr_accessor :eml
        Severity: Minor
        Found in lib/export/dwca/data.rb - About 4 hrs to fix

          Method sv_species_gender_agreement has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
          Open

              def sv_species_gender_agreement
                if is_species_rank?
                  s = part_of_speech_name
                  if !s.nil? && is_available?
                    if %w{adjective participle}.include?(s)
          Severity: Minor
          Found in app/models/protonym/soft_validation_extensions.rb - About 4 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Class TaxonNameClassification has 34 methods (exceeds 20 allowed). Consider refactoring.
          Open

          class TaxonNameClassification < ApplicationRecord
            include Housekeeping
            include Shared::Citations
            include Shared::Notes
            include Shared::IsData
          Severity: Minor
          Found in app/models/taxon_name_classification.rb - About 4 hrs to fix

            Method coordinates_regex_from_verbatim_label has 108 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                def self.coordinates_regex_from_verbatim_label(text)
                  return nil if text.blank?
                  text = text.gsub("''", '"')
                    .gsub('´´', '"')
                    .gsub('ʹʹ', '"')
            Severity: Major
            Found in lib/utilities/geo.rb - About 4 hrs to fix

              Method using_isbn_class has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
              Open

                def using_isbn_class
                  unless identifier.nil?
                    isbn = identifier.upcase
                    # 'ISBN-13: 978-0-596-52068-7'
                    isbn.gsub!('ISBN-10', '')
              Severity: Minor
              Found in app/models/identifier/global/isbn.rb - About 4 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method validate_subject_and_object_ranks has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
              Open

                def validate_subject_and_object_ranks
                  tname = self.type_name
              
                  if tname =~ /TaxonNameRelationship::(Icnp|Icn|Iczn|Icvcn)/ && tname != 'TaxonNameRelationship::Iczn::Validating::UncertainPlacement'
                    rank_group = self.subject_taxon_name.rank_class.try(:parent)
              Severity: Minor
              Found in app/models/taxon_name_relationship.rb - About 4 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method nexml_descriptors has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
              Open

                def nexml_descriptors(options = {})
                  opt = {target: ''}.merge!(options)
                  xml = Builder::XmlMarkup.new(target: opt[:target])
                  m = opt[:observation_matrix]
                  # Multistate characters
              Severity: Minor
              Found in app/helpers/observation_matrices/export/nexml_helper.rb - About 4 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method generate has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
              Open

                def self.generate(otu, project_members, reference_csv = nil)
                   name_total = 0
                  ::CSV.generate(col_sep: "\t") do |csv|
                    csv << %w{
                      ID
              Severity: Minor
              Found in lib/export/coldp/files/name.rb - About 4 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method row_hash_initiate has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
              Open

                def row_hash_initiate
                  h = {}
                  rows = nil # Of either Otu or ObservationMatrixRow of type Otu !! TODO:
                  if observation_matrix_id.to_i == 0 && !otu_filter.blank?
              
              
              Severity: Minor
              Found in lib/tools/image_matrix.rb - About 4 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Class ObservationMatricesController has 33 methods (exceeds 20 allowed). Consider refactoring.
              Open

              class ObservationMatricesController < ApplicationController
                include DataControllerConfiguration::ProjectDataControllerConfiguration
              
                before_action :set_observation_matrix, only: [
                  :show, :api_show, :edit, :update, :destroy,
              Severity: Minor
              Found in app/controllers/observation_matrices_controller.rb - About 4 hrs to fix

                Class TaxonNamesController has 33 methods (exceeds 20 allowed). Consider refactoring.
                Open

                class TaxonNamesController < ApplicationController
                  include DataControllerConfiguration::ProjectDataControllerConfiguration
                
                  before_action :set_taxon_name, only: [:show, :edit, :update, :destroy, :browse, :original_combination, :catalog, :api_show, :api_summary, :api_catalog]
                  after_action -> { set_pagination_headers(:taxon_names) }, only: [:index, :api_index], if: :json_request?
                Severity: Minor
                Found in app/controllers/taxon_names_controller.rb - About 4 hrs to fix

                  Class CollectingEventsController has 33 methods (exceeds 20 allowed). Consider refactoring.
                  Open

                  class CollectingEventsController < ApplicationController
                    include DataControllerConfiguration::ProjectDataControllerConfiguration
                  
                    before_action :set_collecting_event, only: [:show, :edit, :update, :destroy, :card, :clone, :navigation]
                    after_action -> { set_pagination_headers(:collecting_events) }, only: [:index, :api_index], if: :json_request?
                  Severity: Minor
                  Found in app/controllers/collecting_events_controller.rb - About 4 hrs to fix

                    Class Filter has 33 methods (exceeds 20 allowed). Consider refactoring.
                    Open

                        class Filter < Query::Filter
                          include Queries::Concerns::DataAttributes
                          include Queries::Concerns::Notes
                          include Queries::Concerns::Tags
                    
                    
                    Severity: Minor
                    Found in lib/queries/person/filter.rb - About 4 hrs to fix

                      Method include_multistate_matrix has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
                      Open

                        def include_multistate_matrix(options = {})
                          opt = {target: '', descriptors: []}.merge!(options)
                          xml = Builder::XmlMarkup.new(target: opt[:target])
                      
                          m = opt[:observation_matrix]
                      Severity: Minor
                      Found in app/helpers/observation_matrices/export/nexml_helper.rb - About 4 hrs to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Method all_sub_headers has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
                      Open

                        def all_sub_headers(filtered = false)
                          unless filtered
                            ce_headers # generate the header structure (see CollectionObject.selected_column_names)
                            co_headers
                            bc_headers
                      Severity: Minor
                      Found in app/helpers/tasks/gis/report_helper.rb - About 4 hrs to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Severity
                      Category
                      Status
                      Source
                      Language