Sign upLogin

SpontaneousCMS/spontaneous

View on GitHub
Star
application/js/field/image.js

Summary

Maintainability
F
6 days
Test Coverage

Function Image has 350 lines of code (exceeds 25 allowed). Consider refactoring.
Open

Spontaneous.Field.Image = (function($, S) {
    'use strict';
    var dom = S.Dom;
    var ImageFieldConflictView = new JS.Class(S.Field.String.ConflictView, {
Severity: Major
Found in application/js/field/image.js - About 1 day to fix

    Function Image has a Cognitive Complexity of 55 (exceeds 5 allowed). Consider refactoring.
    Open

    Spontaneous.Field.Image = (function($, S) {
    'use strict';
    var dom = S.Dom;
    var ImageFieldConflictView = new JS.Class(S.Field.String.ConflictView, {
    Severity: Minor
    Found in application/js/field/image.js - About 1 day to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function edit has 113 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            edit: function() {
            var wrap = dom.div(),
            drop_wrap = dom.div({'style':'position:relative;'}),
                value = this.currentEditValue(),
                src = value.src,
    Severity: Major
    Found in application/js/field/image.js - About 4 hrs to fix

      File image.js has 353 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      // console.log('Loading ImageField...')
Spontaneous.Field.Image = (function($, S) {
    'use strict';
    var dom = S.Dom;
    var ImageFieldConflictView = new JS.Class(S.Field.String.ConflictView, {
      Severity: Minor
      Found in application/js/field/image.js - About 4 hrs to fix

        Function preview has 84 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                preview: function() {
            Spontaneous.UploadManager.register(this);
            var self = this
, value = this.currentValue()
            , src = value.src
        Severity: Major
        Found in application/js/field/image.js - About 3 hrs to fix

          Function drop has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                      var drop = function(event) {
                event.stopPropagation();
                event.preventDefault();
                dropper.removeClass('drop-active').addClass('uploading');
                var files = event.dataTransfer.files;
          Severity: Minor
          Found in application/js/field/image.js - About 1 hr to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    currentEditValue: function() {
            var value, pending, ui, v = this.get('value');
            if ((pending = v.__pending__)) {
                return pending.value;
            }
            Severity: Major
            Found in application/js/field/image.js and 1 other location - About 4 hrs to fix
            application/js/field/file.js on lines 27..38

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 115.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                        edited.append(dom.img().attr('src', this.values.local_edited)).click(function() {
                this.useValue(this.values.local_edited);
                edited.add(original).removeClass('selected');
                edited.addClass('selected');
            }.bind(this));
            Severity: Major
            Found in application/js/field/image.js and 1 other location - About 3 hrs to fix
            application/js/field/image.js on lines 15..19

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 105.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                        original.append(dom.img().attr('src', this.values.server_original)).click(function() {
                this.useValue(this.values.server_original);
                edited.add(original).removeClass('selected');
                original.addClass('selected');
            }.bind(this));
            Severity: Major
            Found in application/js/field/image.js and 1 other location - About 3 hrs to fix
            application/js/field/image.js on lines 21..25

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 105.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                        var labels = dom.div('.image-field-conflict.labels.differences'),
                outer = dom.div(),
                image_outer = dom.div('.image-field-conflict.changes.differences'),
                original = dom.div('.original.diff'),
                edited = dom.div('.final.diff');
            Severity: Major
            Found in application/js/field/image.js and 1 other location - About 1 hr to fix
            application/js/field/string.js on lines 13..13

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 66.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

                        var drag_enter = function(event) {
                event.stopPropagation();
                event.preventDefault();
                $(this).addClass('drop-active');
                return false;
            Severity: Major
            Found in application/js/field/image.js and 3 other locations - About 1 hr to fix
            application/js/field/image.js on lines 198..203
            application/js/field/image.js on lines 368..373
            application/js/field/image.js on lines 381..386

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 59.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

                        var drag_enter = function(event) {
                event.stopPropagation();
                event.preventDefault();
                $(this).addClass('drop-active');
                return false;
            Severity: Major
            Found in application/js/field/image.js and 3 other locations - About 1 hr to fix
            application/js/field/image.js on lines 185..190
            application/js/field/image.js on lines 198..203
            application/js/field/image.js on lines 381..386

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 59.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

                        var drag_leave = function(event) {
                event.stopPropagation();
                event.preventDefault();
                $(this).removeClass('drop-active');
                return false;
            Severity: Major
            Found in application/js/field/image.js and 3 other locations - About 1 hr to fix
            application/js/field/image.js on lines 185..190
            application/js/field/image.js on lines 198..203
            application/js/field/image.js on lines 368..373

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 59.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

                        var drag_leave = function(event) {
                event.stopPropagation();
                event.preventDefault();
                $(this).removeClass('drop-active');
                return false;
            Severity: Major
            Found in application/js/field/image.js and 3 other locations - About 1 hr to fix
            application/js/field/image.js on lines 185..190
            application/js/field/image.js on lines 368..373
            application/js/field/image.js on lines 381..386

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 59.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    width: function() {
            if (this.data.values && this.currentValue()) {
                return this.currentValue().width;
            }
            return 0;
            Severity: Minor
            Found in application/js/field/image.js and 1 other location - About 55 mins to fix
            application/js/field/image.js on lines 258..263

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 53.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    height: function() {
            if (this.data.values && this.currentValue()) {
                return this.currentValue().height;
            }
            return 0;
            Severity: Minor
            Found in application/js/field/image.js and 1 other location - About 55 mins to fix
            application/js/field/image.js on lines 252..257

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 53.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                                        S.Ajax.test_field_versions(this.content, [this], this.upload_values.bind(this), this.upload_conflict.bind(this));
            Severity: Minor
            Found in application/js/field/image.js and 1 other location - About 40 mins to fix
            application/js/field/file.js on lines 60..60

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 48.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status