Sign upLogin

StairwayB/pundit_roles

View on GitHub
Star

Showing 2 of 11 total issues

Method determine_permitted_associations has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

  def determine_permitted_associations(requested_assoc, pundit_permission, permitted_opts, type)
    permitted_actions = pundit_permission[:associations][type]

    requested_assoc.each do |assoc|
      if assoc.is_a? Symbol or assoc.is_a? String
Severity: Minor
Found in lib/pundit_roles/pundit_associations.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method authorize_associations! has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def authorize_associations!(opts = {query: nil, associations: []})
    raise ArgumentError, 'You must first call authorize!' unless @pundit_primary_permissions.present?

    opts[:query] ||= params[:action].to_s + '?'
Severity: Minor
Found in lib/pundit_roles/pundit_associations.rb - About 1 hr to fix
    Severity
    Category
    Status
    Source
    Language