Sign upLogin

StanislavSol/python-project-83

View on GitHub
Star

Showing 3 of 5 total issues

Function get_urls has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

def get_urls(connection):
    with connection.cursor(cursor_factory=NamedTupleCursor) as curs:
        curs.execute('SELECT id, name FROM urls ORDER BY id DESC;')
        urls = curs.fetchall()
        curs.execute('''SELECT url_id, created_at, status_code
Severity: Minor
Found in page_analyzer/db.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Open

                    if url.id == check.url_id:
                        result.append(url._asdict() | check._asdict())
                        break
                if len(result) == len_result:
Severity: Major
Found in page_analyzer/db.py - About 45 mins to fix

    Function parse_html has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

    def parse_html(url):
    result = {'status': None,
              'head': None,
              'title': None,
              'description': None}
    Severity: Minor
    Found in page_analyzer/html_check.py - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language