Sign upLogin

StarkAndWayne/bosh-cloudfoundry

View on GitHub
Star

Showing 6 of 6 total issues

Class DeploymentAttributes has 38 methods (exceeds 20 allowed). Consider refactoring.
Open

  class DeploymentAttributes
    include BoshExtensions
    include Bosh::Cli::Validation

    attr_reader :attributes
Severity: Minor
Found in lib/bosh/cloudfoundry/deployment_attributes.rb - About 5 hrs to fix

    Method create_cf has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

        def create_cf
      auth_required
      bosh_status # preload

      setup_deployment_attributes
    Severity: Minor
    Found in lib/bosh/cli/commands/02_create_cf.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method create_cf has 40 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def create_cf
      auth_required
      bosh_status # preload

      setup_deployment_attributes
    Severity: Minor
    Found in lib/bosh/cli/commands/02_create_cf.rb - About 1 hr to fix

      Method prepare_cf has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def prepare_cf
      auth_required
      bosh_status

      release_version = options[:release_version] || latest_release_version
      Severity: Minor
      Found in lib/bosh/cli/commands/01_prepare_bosh_for_cf.rb - About 1 hr to fix

        Method prepare_cf has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

            def prepare_cf
      auth_required
      bosh_status

      release_version = options[:release_version] || latest_release_version
        Severity: Minor
        Found in lib/bosh/cli/commands/01_prepare_bosh_for_cf.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method initialize has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            def initialize(director_client, bosh_status, release_version_cpi, attributes = {})
      @director_client = director_client
      @bosh_status = bosh_status
      @release_version_cpi = release_version_cpi
      @attributes = attributes
        Severity: Minor
        Found in lib/bosh/cloudfoundry/deployment_attributes.rb - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language