Sign upLogin

SteelHouseLabs/apolo

View on GitHub
Star

Showing 2 of 4 total issues

Method number_of_connections has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
Open

      def number_of_connections(filter=nil, inverse=false)
        applications = `db2 list applications for database #{@database}`.split("\n")

        if applications[0] =~ /\ASQL30082N/
          # security problem with user and/or password
Severity: Minor
Found in lib/apolo/domains/db2.rb - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method number_of_connections has 56 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def number_of_connections(filter=nil, inverse=false)
        applications = `db2 list applications for database #{@database}`.split("\n")

        if applications[0] =~ /\ASQL30082N/
          # security problem with user and/or password
Severity: Major
Found in lib/apolo/domains/db2.rb - About 2 hrs to fix
    Severity
    Category
    Status
    Source
    Language