Sign upLogin

Strider-CD/strider

View on GitHub
Star
apps/strider/dist-lib/auth.js

Summary

Maintainability
F
2 wks
Test Coverage

File auth.js has 286 lines of code (exceeds 250 allowed). Consider refactoring.
Open

const crypto = require('crypto');
const BluebirdPromise = require('bluebird');
const passport = require('passport');
const LocalStrategy = require('passport-local').Strategy;
const utils = require('./utils');
Severity: Minor
Found in apps/strider/dist-lib/auth.js - About 2 hrs to fix

    Function registerRoutes has 47 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function registerRoutes(app) {
    app.get('/register', function (req, res, next) {
        if (req.query.ember) {
            return next();
        }
    Severity: Minor
    Found in apps/strider/dist-lib/auth.js - About 1 hr to fix

      Function forgot has 43 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function forgot(req, res) {
    const email = req.body.email.toLowerCase();
    User.findOne({ email: { $regex: new RegExp(email, 'i') } }, function (error, user) {
        if (error) {
            return res.status(400).json({
      Severity: Minor
      Found in apps/strider/dist-lib/auth.js - About 1 hr to fix

        Function setup has 32 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function setup(app) {
    app.registerAuthStrategy = function (strategy) {
        passport.use(strategy);
    };
    app.authenticate = function () {
        Severity: Minor
        Found in apps/strider/dist-lib/auth.js - About 1 hr to fix

          Function resetPost has 31 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          function resetPost(req, res) {
    const password = req.body.password;
    const confirmation = req.body.passwordConfirmation;
    if (password === confirmation) {
        User.findOne({
          Severity: Minor
          Found in apps/strider/dist-lib/auth.js - About 1 hr to fix

            Function basicAuth has 26 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            function basicAuth(req, res, next) {
    const auth = req.get('authorization');
    if (!auth)
        return next();
    const parts = auth.split(' ');
            Severity: Minor
            Found in apps/strider/dist-lib/auth.js - About 1 hr to fix

              Function requireProjectAdmin has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

              function requireProjectAdmin(req, res, next) {
    if (!req.project)
        return res.status(404).send('Project not loaded');
    if (!req.user)
        return res.status(401).send('No user');
              Severity: Minor
              Found in apps/strider/dist-lib/auth.js - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

              function registerRoutes(app) {
    app.get('/register', function (req, res, next) {
        if (req.query.ember) {
            return next();
        }
              Severity: Major
              Found in apps/strider/dist-lib/auth.js and 1 other location - About 2 days to fix
              apps/strider/lib/auth.js on lines 34..97

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 497.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

              function setup(app) {
    app.registerAuthStrategy = function (strategy) {
        passport.use(strategy);
    };
    app.authenticate = function () {
              Severity: Major
              Found in apps/strider/dist-lib/auth.js and 1 other location - About 2 days to fix
              apps/strider/lib/auth.js on lines 99..149

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 388.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

              function forgot(req, res) {
    const email = req.body.email.toLowerCase();
    User.findOne({ email: { $regex: new RegExp(email, 'i') } }, function (error, user) {
        if (error) {
            return res.status(400).json({
              Severity: Major
              Found in apps/strider/dist-lib/auth.js and 1 other location - About 2 days to fix
              apps/strider/lib/auth.js on lines 189..238

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 372.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

              function basicAuth(req, res, next) {
    const auth = req.get('authorization');
    if (!auth)
        return next();
    const parts = auth.split(' ');
              Severity: Major
              Found in apps/strider/dist-lib/auth.js and 1 other location - About 1 day to fix
              apps/strider/lib/auth.js on lines 151..180

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 289.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

              function resetPost(req, res) {
    const password = req.body.password;
    const confirmation = req.body.passwordConfirmation;
    if (password === confirmation) {
        User.findOne({
              Severity: Major
              Found in apps/strider/dist-lib/auth.js and 1 other location - About 1 day to fix
              apps/strider/lib/auth.js on lines 267..309

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 287.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

              function requireProjectAdmin(req, res, next) {
    if (!req.project)
        return res.status(404).send('Project not loaded');
    if (!req.user)
        return res.status(401).send('No user');
              Severity: Major
              Found in apps/strider/dist-lib/auth.js and 1 other location - About 6 hrs to fix
              apps/strider/lib/auth.js on lines 341..349

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 164.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

              function reset(req, res, next) {
    if (req.query.ember) {
        return next();
    }
    const token = req.params.token;
              Severity: Major
              Found in apps/strider/dist-lib/auth.js and 1 other location - About 5 hrs to fix
              apps/strider/lib/auth.js on lines 240..265

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 149.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

              function setupPasswordAuth() {
    passport.use(new LocalStrategy({
        usernameField: 'email',
    }, function (username, password, done) {
        console.log('username: %s', username);
              Severity: Major
              Found in apps/strider/dist-lib/auth.js and 1 other location - About 4 hrs to fix
              apps/strider/lib/auth.js on lines 12..32

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 117.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

              function requireAdminOr401(req, res, next) {
    if (!req.user || !req.user['account_level'] || req.user.account_level < 1) {
        res.status(401).send('not authorized');
    }
    else {
              Severity: Major
              Found in apps/strider/dist-lib/auth.js and 1 other location - About 2 hrs to fix
              apps/strider/lib/auth.js on lines 330..336

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 89.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

              function requireUser(req, res, next) {
    if (req.user) {
        next();
    }
    else {
              Severity: Major
              Found in apps/strider/dist-lib/auth.js and 1 other location - About 1 hr to fix
              apps/strider/lib/auth.js on lines 312..319

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 64.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

              module.exports = {
    setup: setup,
    authenticate: _authenticate,
    logout: logout,
    forgot: forgot,
              Severity: Major
              Found in apps/strider/dist-lib/auth.js and 1 other location - About 1 hr to fix
              apps/strider/lib/auth.js on lines 351..364

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 63.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

              function requireUserOr401(req, res, next) {
    if (req.user) {
        next();
    }
    else {
              Severity: Minor
              Found in apps/strider/dist-lib/auth.js and 1 other location - About 55 mins to fix
              apps/strider/lib/auth.js on lines 321..327

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 53.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status