Sign upLogin

Strider-CD/strider

View on GitHub
Star
apps/strider/dist-lib/jobs.js

Summary

Maintainability
F
1 wk
Test Coverage

Function jobSort has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

function jobSort(a, b) {
    if (a.nojobs) {
        if (b.nojobs)
            return 0;
        return -1;
Severity: Minor
Found in apps/strider/dist-lib/jobs.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function jobSort has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function jobSort(a, b) {
    if (a.nojobs) {
        if (b.nojobs)
            return 0;
        return -1;
Severity: Minor
Found in apps/strider/dist-lib/jobs.js - About 1 hr to fix

    Avoid too many return statements within this function.
    Open

            return 1;
    Severity: Major
    Found in apps/strider/dist-lib/jobs.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

          return 'passed';
      Severity: Major
      Found in apps/strider/dist-lib/jobs.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

            return b.finished.getTime() - a.finished.getTime();
        Severity: Major
        Found in apps/strider/dist-lib/jobs.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                  return 'failed';
          Severity: Major
          Found in apps/strider/dist-lib/jobs.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                    return 1;
            Severity: Major
            Found in apps/strider/dist-lib/jobs.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                      return 1;
              Severity: Major
              Found in apps/strider/dist-lib/jobs.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                        return -1;
                Severity: Major
                Found in apps/strider/dist-lib/jobs.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                          return -1;
                  Severity: Major
                  Found in apps/strider/dist-lib/jobs.js - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                                return 0;
                    Severity: Major
                    Found in apps/strider/dist-lib/jobs.js - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                              return -1;
                      Severity: Major
                      Found in apps/strider/dist-lib/jobs.js - About 30 mins to fix

                        Function status has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                        Open

                        function status(job) {
    if (job.errored)
        return 'errored';
    if (!job.started)
        return 'submitted';
                        Severity: Minor
                        Found in apps/strider/dist-lib/jobs.js - About 25 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Identical blocks of code found in 2 locations. Consider refactoring.
                        Open

                        function latestPublicJobs(user, small, done) {
    // If we are an admin, all projects will be returned in UserJobs
    if (user && user.account_level > 0)
        return done(null, []);
    if (arguments.length === 2) {
                        Severity: Major
                        Found in apps/strider/dist-lib/jobs.js and 1 other location - About 1 day to fix
                        apps/strider/lib/jobs.js on lines 118..145

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 271.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Identical blocks of code found in 2 locations. Consider refactoring.
                        Open

                        function latestJob(project, user, small, done) {
    let query = Job.find({ project: project.name.toLowerCase(), archived: null })
        .sort({ finished: -1 })
        .limit(6)
        .lean();
                        Severity: Major
                        Found in apps/strider/dist-lib/jobs.js and 1 other location - About 1 day to fix
                        apps/strider/lib/jobs.js on lines 77..100

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 247.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Identical blocks of code found in 2 locations. Consider refactoring.
                        Open

                        function jobSort(a, b) {
    if (a.nojobs) {
        if (b.nojobs)
            return 0;
        return -1;
                        Severity: Major
                        Found in apps/strider/dist-lib/jobs.js and 1 other location - About 1 day to fix
                        apps/strider/lib/jobs.js on lines 158..177

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 227.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Identical blocks of code found in 2 locations. Consider refactoring.
                        Open

                        function projectJobs(projects, user, small, done) {
    if (arguments.length === 2) {
        done = small;
        small = false;
    }
                        Severity: Major
                        Found in apps/strider/dist-lib/jobs.js and 1 other location - About 5 hrs to fix
                        apps/strider/lib/jobs.js on lines 102..116

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 137.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Identical blocks of code found in 2 locations. Consider refactoring.
                        Open

                        function small(job) {
    const big = ['phases', 'plugin_data', 'std', 'stderr', 'stdout', 'stdmerged'];
    const njob = {};
    if (job.toJSON)
        job = job.toJSON();
                        Severity: Major
                        Found in apps/strider/dist-lib/jobs.js and 1 other location - About 4 hrs to fix
                        apps/strider/lib/jobs.js on lines 50..60

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 118.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Identical blocks of code found in 2 locations. Consider refactoring.
                        Open

                        function latestJobs(user, small, done) {
    if (arguments.length === 2) {
        done = small;
        small = false;
    }
                        Severity: Major
                        Found in apps/strider/dist-lib/jobs.js and 1 other location - About 3 hrs to fix
                        apps/strider/lib/jobs.js on lines 28..38

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 107.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Identical blocks of code found in 2 locations. Consider refactoring.
                        Open

                        function jobProject(project, prev, user) {
    prev.forEach(function (job) {
        job.status = status(job);
    });
    project = utils.sanitizeProject(project);
                        Severity: Major
                        Found in apps/strider/dist-lib/jobs.js and 1 other location - About 3 hrs to fix
                        apps/strider/lib/jobs.js on lines 62..75

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 99.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Identical blocks of code found in 2 locations. Consider refactoring.
                        Open

                        function status(job) {
    if (job.errored)
        return 'errored';
    if (!job.started)
        return 'submitted';
                        Severity: Major
                        Found in apps/strider/dist-lib/jobs.js and 1 other location - About 2 hrs to fix
                        apps/strider/lib/jobs.js on lines 41..48

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 93.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Identical blocks of code found in 2 locations. Consider refactoring.
                        Open

                        function latestUsersJobs(user, small, done) {
    if (arguments.length === 2) {
        done = small;
        small = false;
    }
                        Severity: Major
                        Found in apps/strider/dist-lib/jobs.js and 1 other location - About 2 hrs to fix
                        apps/strider/lib/jobs.js on lines 147..156

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 80.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        There are no issues that match your filters.

                        Category
                        Status