Sign upLogin

Strider-CD/strider

View on GitHub
Star
apps/strider/lib/backchannel.js

Summary

Maintainability
F
2 wks
Test Coverage

File backchannel.js has 309 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*
 * Backchannel server allows workers to stream messages back to the Node server
 * in a line-buffered way. Uses SSL.
 */
Severity: Minor
Found in apps/strider/lib/backchannel.js - About 3 hrs to fix

    Function prepareJob has 78 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function prepareJob(emitter, job) {
  Project.findOne({ name: job.project })
    .populate('creator')
    .exec(function (err, project) {
      if (err || !project)
    Severity: Major
    Found in apps/strider/lib/backchannel.js - About 3 hrs to fix

      Function newJob has 38 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        newJob: function (job) {
    debug('new job was created');
    const name = job.project.name;

    this.waiting[name] = [];
      Severity: Minor
      Found in apps/strider/lib/backchannel.js - About 1 hr to fix

        Function jobDone has 32 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          jobDone: function (emitter, data) {
    Job.findById(data.id, (err, job) => {
      if (err) return debug('Error finding job', err.message);
      if (!job) return debug('job.done but job not found:', data.id);
      _.extend(job, data);
        Severity: Minor
        Found in apps/strider/lib/backchannel.js - About 1 hr to fix

          Function jobErrored has 32 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            jobErrored: function (emitter, data) {
    Job.findById(data.id, (err, job) => {
      if (err) return debug('Error finding job', err.message);
      if (!job) return debug('job.done but job not found:', data.id);
      _.extend(job, data);
          Severity: Minor
          Found in apps/strider/lib/backchannel.js - About 1 hr to fix

            Function striderJson has 32 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            function striderJson(provider, project, ref, done) {
  function finished(err, contents) {
    if (err || !contents) return done(err);

    let data = {};
            Severity: Minor
            Found in apps/strider/lib/backchannel.js - About 1 hr to fix

              Function sendJobs has 29 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                sendJobs: function (project, event, args) {
    if (this.users[project]) {
      this.ws.sendEach(this.users[project], function (user) {
        return [
          event,
              Severity: Minor
              Found in apps/strider/lib/backchannel.js - About 1 hr to fix

                Function onUpdate has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                Open

                  onUpdate: function (project, event, args) {
    if (this.waiting[project]) {
      return this.waiting[project].push([event, args]);
    }
    this.send(project, event, args);
                Severity: Minor
                Found in apps/strider/lib/backchannel.js - About 45 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function jobDone has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                  jobDone: function (emitter, data) {
    Job.findById(data.id, (err, job) => {
      if (err) return debug('Error finding job', err.message);
      if (!job) return debug('job.done but job not found:', data.id);
      _.extend(job, data);
                Severity: Minor
                Found in apps/strider/lib/backchannel.js - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function striderJson has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                function striderJson(provider, project, ref, done) {
  function finished(err, contents) {
    if (err || !contents) return done(err);

    let data = {};
                Severity: Minor
                Found in apps/strider/lib/backchannel.js - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function jobErrored has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                  jobErrored: function (emitter, data) {
    Job.findById(data.id, (err, job) => {
      if (err) return debug('Error finding job', err.message);
      if (!job) return debug('job.done but job not found:', data.id);
      _.extend(job, data);
                Severity: Minor
                Found in apps/strider/lib/backchannel.js - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                BackChannel.prototype = {
  send: function (project, event, args) {
    if (this.users[project]) {
      this.ws.send(this.users[project], [event, args, 'yours']);
    }
                Severity: Major
                Found in apps/strider/lib/backchannel.js and 1 other location - About 1 wk to fix
                apps/strider/dist-lib/backchannel.js on lines 126..287

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 1829.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                function prepareJob(emitter, job) {
  Project.findOne({ name: job.project })
    .populate('creator')
    .exec(function (err, project) {
      if (err || !project)
                Severity: Major
                Found in apps/strider/lib/backchannel.js and 1 other location - About 4 days to fix
                apps/strider/dist-lib/backchannel.js on lines 50..114

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 736.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                function striderJson(provider, project, ref, done) {
  function finished(err, contents) {
    if (err || !contents) return done(err);

    let data = {};
                Severity: Major
                Found in apps/strider/lib/backchannel.js and 1 other location - About 1 day to fix
                apps/strider/dist-lib/backchannel.js on lines 16..35

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 202.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                function BackChannel(emitter, ws) {
  this.ws = ws;
  this.users = {};
  this.public = {};
  this.waiting = {};
                Severity: Major
                Found in apps/strider/lib/backchannel.js and 1 other location - About 7 hrs to fix
                apps/strider/dist-lib/backchannel.js on lines 115..125

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 176.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status