Sign upLogin

Strider-CD/strider

View on GitHub
Star
apps/strider/lib/routes/api/repo.js

Summary

Maintainability
F
2 wks
Test Coverage

Function createProject has 153 lines of code (exceeds 25 allowed). Consider refactoring.
Open

exports.createProject = function (req, res, next) {
  if (req.params.org === 'auth') {
    return next();
  }
Severity: Major
Found in apps/strider/lib/routes/api/repo.js - About 6 hrs to fix

    Function createProject has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
    Open

    exports.createProject = function (req, res, next) {
  if (req.params.org === 'auth') {
    return next();
  }
    Severity: Minor
    Found in apps/strider/lib/routes/api/repo.js - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File repo.js has 269 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /*
 * Repo-specific actions - such as deactivation, deletion etc.
 * routes/api/repo.js
 */
    Severity: Minor
    Found in apps/strider/lib/routes/api/repo.js - About 2 hrs to fix

      Function deleteProject has 56 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      exports.deleteProject = function (req, res) {
  async.parallel(
    [
      function (next) {
        const provider = req.project.provider;
      Severity: Major
      Found in apps/strider/lib/routes/api/repo.js - About 2 hrs to fix

        Function createProjectWithKey has 54 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          function createProjectWithKey(err, privkey, pubkey) {
    if (err) return error(500, 'Failed to generate ssh keypair');

    const project = {
      name: name,
        Severity: Major
        Found in apps/strider/lib/routes/api/repo.js - About 2 hrs to fix

          Function projectCreated has 30 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            function projectCreated(err, p) {
    if (err) {
      debug(`Error creating repo ${name} for user ${req.user.email}: ${err}`);
      debug(err.stack);
      return error(500, 'internal server error');
          Severity: Minor
          Found in apps/strider/lib/routes/api/repo.js - About 1 hr to fix

            Avoid too many return statements within this function.
            Open

                return error(400, 'Invalid project type specified');
            Severity: Major
            Found in apps/strider/lib/routes/api/repo.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                    return error(400, 'provider.repo_id is required');
              Severity: Major
              Found in apps/strider/lib/routes/api/repo.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                    return error(
      400,
      'Project type specified is not available; one or more required plugins is not installed'
    );
                Severity: Major
                Found in apps/strider/lib/routes/api/repo.js - About 30 mins to fix

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                  exports.createProject = function (req, res, next) {
  if (req.params.org === 'auth') {
    return next();
  }
                  Severity: Major
                  Found in apps/strider/lib/routes/api/repo.js and 1 other location - About 1 wk to fix
                  apps/strider/dist-lib/routes/api/repo.js on lines 92..224

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 1245.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                  exports.deleteProject = function (req, res) {
  async.parallel(
    [
      function (next) {
        const provider = req.project.provider;
                  Severity: Major
                  Found in apps/strider/lib/routes/api/repo.js and 1 other location - About 2 days to fix
                  apps/strider/dist-lib/routes/api/repo.js on lines 237..272

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 414.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                  function clearProjectCache(project, cb) {
  const runners = [];
  const tasks = [];

  project.branches.forEach(function (branch) {
                  Severity: Major
                  Found in apps/strider/lib/routes/api/repo.js and 1 other location - About 1 day to fix
                  apps/strider/dist-lib/routes/api/repo.js on lines 54..75

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 252.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                  function makePlugins(plugins) {
  const configs = [];
  let plugin;

  for (let i = 0; i < plugins.length; i++) {
                  Severity: Major
                  Found in apps/strider/lib/routes/api/repo.js and 1 other location - About 4 hrs to fix
                  apps/strider/dist-lib/routes/api/repo.js on lines 13..28

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 132.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                  exports.clearCache = function (req, res) {
  clearProjectCache(req.project, function (err, result) {
    if (err) {
      return res.status(500).send('failed to clear cache');
    }
                  Severity: Major
                  Found in apps/strider/lib/routes/api/repo.js and 1 other location - About 3 hrs to fix
                  apps/strider/dist-lib/routes/api/repo.js on lines 41..53

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 98.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status