Sign upLogin

Strider-CD/strider

View on GitHub
Star
clients/classic-ui/client/config/controllers/config.js

Summary

Maintainability
F
1 wk
Test Coverage

Function ConfigController has 482 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function ConfigController($scope) {
  // this is the parent controller.
  $scope.project = project;
  $scope.plugins = plugins;
  $scope.runners = runners;
Severity: Major
Found in clients/classic-ui/client/config/controllers/config.js - About 2 days to fix

    Function ConfigController has a Cognitive Complexity of 106 (exceeds 5 allowed). Consider refactoring.
    Open

    function ConfigController($scope) {
  // this is the parent controller.
  $scope.project = project;
  $scope.plugins = plugins;
  $scope.runners = runners;
    Severity: Minor
    Found in clients/classic-ui/client/config/controllers/config.js - About 2 days to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File config.js has 517 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    'use strict';

var $ = require('jquery');
var _ = require('lodash');
var md5 = require('md5');
    Severity: Major
    Found in clients/classic-ui/client/config/controllers/config.js - About 1 day to fix

      Function pluginConfig has 41 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        $scope.pluginConfig = function (name, branch, data, next) {
    if (arguments.length === 3) {
      next = data;
      data = branch;
      branch = $scope.branch;
      Severity: Minor
      Found in clients/classic-ui/client/config/controllers/config.js - About 1 hr to fix

        Function ConfigPageRouting has 40 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          $(function ConfigPageRouting() {
    var router = {
      init: function () {
        var self = this;
        Severity: Minor
        Found in clients/classic-ui/client/config/controllers/config.js - About 1 hr to fix

          Function initBranch has 32 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            function initBranch(branch) {
    var plugins;

    $scope.configured[branch.name] = {};
    $scope.configs[branch.name] = {};
          Severity: Minor
          Found in clients/classic-ui/client/config/controllers/config.js - About 1 hr to fix

            Function runnerConfig has 31 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              $scope.runnerConfig = function (branch, data, next) {
    if (arguments.length === 2) {
      next = data;
      data = branch;
      branch = $scope.branch;
            Severity: Minor
            Found in clients/classic-ui/client/config/controllers/config.js - About 1 hr to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                $scope.startDeploy = function (name) {
    $.ajax({
      url: `/${$scope.project.name}/start`,
      data: {branch: $scope.branch.name, type: 'TEST_AND_DEPLOY', page: 'config'},
      type: 'POST',
              Severity: Major
              Found in clients/classic-ui/client/config/controllers/config.js and 1 other location - About 1 day to fix
              clients/classic-ui/client/config/controllers/config.js on lines 556..571

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 211.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                $scope.startTest = function (name) {
    $.ajax({
      url: `/${$scope.project.name}/start`,
      data: {branch: $scope.branch.name, type: 'TEST_ONLY', page: 'config'},
      type: 'POST',
              Severity: Major
              Found in clients/classic-ui/client/config/controllers/config.js and 1 other location - About 1 day to fix
              clients/classic-ui/client/config/controllers/config.js on lines 574..589

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 211.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                      if (xhr && xhr.responseText) {
          var data = $.parseJSON(xhr.responseText);
          $scope.error(`Error saving runner config: ${data.errors[0]}`);
        } else {
          $scope.error(`Error saving runner config: ${e}`);
              Severity: Major
              Found in clients/classic-ui/client/config/controllers/config.js and 2 other locations - About 2 hrs to fix
              clients/classic-ui/client/config/controllers/deactivate.js on lines 23..28
              clients/classic-ui/client/config/controllers/deactivate.js on lines 50..55

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 86.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                $('[data-toggle=tab]').on('shown', function (e) {
    var tabId = $(e.target).attr('href');
    $(tabId).find('[ui-codemirror]').trigger('refresh');
  });
              Severity: Major
              Found in clients/classic-ui/client/config/controllers/config.js and 1 other location - About 1 hr to fix
              clients/classic-ui/client/config/controllers/config.js on lines 34..37

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 70.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                  $('[data-toggle=tab]').on('shown', function (e) {
      var tabId = $(e.target).attr('href');
      $(tabId).find('[ui-codemirror]').trigger('refresh');
    });
              Severity: Major
              Found in clients/classic-ui/client/config/controllers/config.js and 1 other location - About 1 hr to fix
              clients/classic-ui/client/config/controllers/config.js on lines 132..135

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 70.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  saveProjectConfig({plugin_order: data}, branch, project, function (err) {
      if (err) {
        return $scope.error(`Error saving plugin order on branch ${branch.name}: ${err}`, true);
      }
              Severity: Major
              Found in clients/classic-ui/client/config/controllers/config.js and 1 other location - About 1 hr to fix
              clients/classic-ui/client/config/controllers/config.js on lines 368..374

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 68.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  saveProjectConfig(data, branch, project, function (err) {
      if (err) {
        return $scope.error(`Error saving general config for branch ${branch.name}: ${err}`, true);
      }
              Severity: Major
              Found in clients/classic-ui/client/config/controllers/config.js and 1 other location - About 1 hr to fix
              clients/classic-ui/client/config/controllers/config.js on lines 243..249

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 68.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status