Sign upLogin

Strider-CD/strider

View on GitHub
Star
clients/classic-ui/client/job-status/controllers/job.js

Summary

Maintainability
F
4 days
Test Coverage

Function exports has a Cognitive Complexity of 51 (exceeds 5 allowed). Consider refactoring.
Open

module.exports = function($scope, $route, $location, $filter) {
  var params = $route.current ? $route.current.params : {};
  var project = global.project;
  var jobid = params.id || (global.job && global.job._id);
  var socket = io.connect();
Severity: Minor
Found in clients/classic-ui/client/job-status/controllers/job.js - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function exports has 148 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function($scope, $route, $location, $filter) {
  var params = $route.current ? $route.current.params : {};
  var project = global.project;
  var jobid = params.id || (global.job && global.job._id);
  var socket = io.connect();
Severity: Major
Found in clients/classic-ui/client/job-status/controllers/job.js - About 5 hrs to fix

    Function addJob has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
    Open

      addJob(job) {
    if ((job.project.name || job.project) !== this.project) return;
    this.jobs[job._id] = job;
    var found = -1;
    Severity: Minor
    Found in clients/classic-ui/client/job-status/controllers/job.js - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File job.js has 281 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    'use strict';

var _ = require('lodash');
var bootbox = require('bootbox');
var $ = require('jquery');
    Severity: Minor
    Found in clients/classic-ui/client/job-status/controllers/job.js - About 2 hrs to fix

      Function addJob has 41 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        addJob(job) {
    if ((job.project.name || job.project) !== this.project) return;
    this.jobs[job._id] = job;
    var found = -1;
      Severity: Minor
      Found in clients/classic-ui/client/job-status/controllers/job.js - About 1 hr to fix

        Function handleLocationChange has 36 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          function handleLocationChange(force) {
    if (global.location.pathname.match(/\/config$/)) {
      // eslint-disable-next-line no-self-assign
      global.location = global.location;
      return;
        Severity: Minor
        Found in clients/classic-ui/client/job-status/controllers/job.js - About 1 hr to fix

          Function buildSwitcher has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
          Open

          function buildSwitcher($scope) {
  function switchBuilds(evt) {
    var dy = { 40: 1, 38: -1 }[evt.keyCode];
    var id = $scope.job._id;
    var idx;
          Severity: Minor
          Found in clients/classic-ui/client/job-status/controllers/job.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function BuildPage has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          function BuildPage(socket, project, change, scope, jobs, job) {
          Severity: Minor
          Found in clients/classic-ui/client/job-status/controllers/job.js - About 45 mins to fix

            Function updateFavicon has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

            function updateFavicon(value) {
  if (value === 'running') {
    if (runtime === null) {
      runtime = animateFav();
    }
            Severity: Minor
            Found in clients/classic-ui/client/job-status/controllers/job.js - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

              if ($scope.job && $scope.job.phases.test.commands.length) {
    if (job.phases.environment) {
      job.phases.environment.collapsed = true;
    }
    if (job.phases.prepare) {
            Severity: Major
            Found in clients/classic-ui/client/job-status/controllers/job.js and 1 other location - About 3 hrs to fix
            clients/classic-ui/client/job-status/controllers/job.js on lines 240..250

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 106.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                  if (job.phases.test.commands.length) {
        if (job.phases.environment) {
          job.phases.environment.collapsed = true;
        }
        if (job.phases.prepare) {
            Severity: Major
            Found in clients/classic-ui/client/job-status/controllers/job.js and 1 other location - About 3 hrs to fix
            clients/classic-ui/client/job-status/controllers/job.js on lines 40..50

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 106.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              $scope.startTest = function(job) {
    $('.tooltip').hide();
    socket.emit('test', project.name, job && job.ref.branch);
    $scope.job = {
      project: $scope.job.project,
            Severity: Major
            Found in clients/classic-ui/client/job-status/controllers/job.js and 1 other location - About 2 hrs to fix
            clients/classic-ui/client/job-status/controllers/job.js on lines 170..177

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 89.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              $scope.startDeploy = function(job) {
    $('.tooltip').hide();
    socket.emit('deploy', project.name, job && job.ref.branch);
    $scope.job = {
      project: $scope.job.project,
            Severity: Major
            Found in clients/classic-ui/client/job-status/controllers/job.js and 1 other location - About 2 hrs to fix
            clients/classic-ui/client/job-status/controllers/job.js on lines 178..185

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 89.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                for (var i = 0; i < $scope.jobs.length; i++) {
      if ($scope.jobs[i]._id === id) {
        idx = i;
        break;
      }
            Severity: Major
            Found in clients/classic-ui/client/job-status/controllers/job.js and 1 other location - About 1 hr to fix
            modules/strider-runner-core/lib/job.js on lines 274..279

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 62.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status