Strider-CD/strider

View on GitHub
common/scripts/install-run.js

Summary

Maintainability
C
1 day
Test Coverage

File install-run.js has 344 lines of code (exceeds 250 allowed). Consider refactoring.
Open

"use strict";
// Copyright (c) Microsoft Corporation. All rights reserved. Licensed under the MIT license.
// See the @microsoft/rush package's LICENSE file for license information.
Object.defineProperty(exports, "__esModule", { value: true });
// THIS FILE WAS GENERATED BY A TOOL. ANY MANUAL MODIFICATIONS WILL GET OVERWRITTEN WHENEVER RUSH IS UPGRADED.
Severity: Minor
Found in common/scripts/install-run.js - About 4 hrs to fix

    Function _copyAndTrimNpmrcFile has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
    Open

    function _copyAndTrimNpmrcFile(sourceNpmrcPath, targetNpmrcPath) {
        console.log(`Copying ${sourceNpmrcPath} --> ${targetNpmrcPath}`); // Verbose
        let npmrcFileLines = fs.readFileSync(sourceNpmrcPath).toString().split('\n');
        npmrcFileLines = npmrcFileLines.map((line) => (line || '').trim());
        const resultLines = [];
    Severity: Minor
    Found in common/scripts/install-run.js - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _resolvePackageVersion has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

    function _resolvePackageVersion(rushCommonFolder, { name, version }) {
        if (!version) {
            version = '*'; // If no version is specified, use the latest version
        }
        if (version.match(/^[a-zA-Z0-9\-\+\.]+$/)) {
    Severity: Minor
    Found in common/scripts/install-run.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _copyAndTrimNpmrcFile has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function _copyAndTrimNpmrcFile(sourceNpmrcPath, targetNpmrcPath) {
        console.log(`Copying ${sourceNpmrcPath} --> ${targetNpmrcPath}`); // Verbose
        let npmrcFileLines = fs.readFileSync(sourceNpmrcPath).toString().split('\n');
        npmrcFileLines = npmrcFileLines.map((line) => (line || '').trim());
        const resultLines = [];
    Severity: Minor
    Found in common/scripts/install-run.js - About 1 hr to fix

      Function installAndRun has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function installAndRun(packageName, packageVersion, packageBinName, packageBinArgs) {
          const rushJsonFolder = findRushJsonFolder();
          const rushCommonFolder = path.join(rushJsonFolder, 'common');
          const rushTempFolder = _getRushTempFolder(rushCommonFolder);
          const packageInstallFolder = _ensureAndJoinPath(rushTempFolder, 'install-run', `${packageName}@${packageVersion}`);
      Severity: Minor
      Found in common/scripts/install-run.js - About 1 hr to fix

        Function findRushJsonFolder has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

        function findRushJsonFolder() {
            if (!_rushJsonFolder) {
                let basePath = __dirname;
                let tempPath = __dirname;
                do {
        Severity: Minor
        Found in common/scripts/install-run.js - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function getNpmPath has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

        function getNpmPath() {
            if (!_npmPath) {
                try {
                    if (os.platform() === 'win32') {
                        // We're on Windows
        Severity: Minor
        Found in common/scripts/install-run.js - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid deeply nested control flow statements.
        Open

                            if (!process.env[environmentVariableName]) {
                                // No, so trim this line
                                lineShouldBeTrimmed = true;
                                break;
                            }
        Severity: Major
        Found in common/scripts/install-run.js - About 45 mins to fix

          There are no issues that match your filters.

          Category
          Status