Sign upLogin

SuitestAutomation/suitest-js-api

View on GitHub
Star
lib/chains/windowChain.js

Summary

Maintainability
D
2 days
Test Coverage
A
90%

Function windowFactory has a Cognitive Complexity of 45 (exceeds 5 allowed). Consider refactoring.
Open

const windowFactory = (classInstance) => {
    /**
     * @description get browser command type basing on internal chain data
     * @param data
     * @returns {'refresh' | 'goBack' | 'goForward' | 'setWindowSize' | 'dismissAlertMessage' | 'acceptPromptMessage' | 'acceptAlertMessage'}
Severity: Minor
Found in lib/chains/windowChain.js - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function windowFactory has 102 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const windowFactory = (classInstance) => {
    /**
     * @description get browser command type basing on internal chain data
     * @param data
     * @returns {'refresh' | 'goBack' | 'goForward' | 'setWindowSize' | 'dismissAlertMessage' | 'acceptPromptMessage' | 'acceptAlertMessage'}
Severity: Major
Found in lib/chains/windowChain.js - About 4 hrs to fix

    Function toJSON has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        const toJSON = (data) => {
        const lineType = !isNil(data.sendText) ? 'sendText' : 'browserCommand';
        const socketMessage = {
            type: getRequestType(data, false),
            request: {type: lineType},
    Severity: Minor
    Found in lib/chains/windowChain.js - About 1 hr to fix

      Function getComposers has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          const getComposers = (data) => {
        const output = [
            toStringComposer,
            thenComposer,
            cloneComposer,
      Severity: Minor
      Found in lib/chains/windowChain.js - About 1 hr to fix

        Avoid too many return statements within this function.
        Open

                    return 'acceptAlertMessage';
        Severity: Major
        Found in lib/chains/windowChain.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                      return 'dismissAlertMessage';
          Severity: Major
          Found in lib/chains/windowChain.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                        return 'acceptPromptMessage';
            Severity: Major
            Found in lib/chains/windowChain.js - About 30 mins to fix

              Identical blocks of code found in 5 locations. Consider refactoring.
              Open

                      if (!isNil(data.sendText)) {
            if (!data.interval) {
                output.push(intervalComposer);
            }
              Severity: Major
              Found in lib/chains/windowChain.js and 4 other locations - About 2 hrs to fix
              lib/chains/applicationChain.js on lines 103..117
              lib/chains/elementChain.js on lines 316..328
              lib/chains/positionChain.js on lines 109..121
              lib/chains/relativePositionChain.js on lines 89..101

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 76.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status