Sign upLogin

SuitestAutomation/suitest-js-api

View on GitHub
Star
lib/utils/socketChainHelper.js

Summary

Maintainability
D
1 day
Test Coverage
B
88%

Function processServerResponse has a Cognitive Complexity of 40 (exceeds 5 allowed). Consider refactoring.
Open

const processServerResponse = (logger, verbosity) =>
    function processServerResponseHandler(res, data, jsonMessage, snippets) {
        const isSnippet = data.type === 'runSnippet';
        const isAssertionError = isSnippet || assertionErrorTypes.includes(normalizeErrorType(res));
        const responseForError = getResponseForError(res);
Severity: Minor
Found in lib/utils/socketChainHelper.js - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function processServerResponseHandler has 105 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    function processServerResponseHandler(res, data, jsonMessage, snippets) {
        const isSnippet = data.type === 'runSnippet';
        const isAssertionError = isSnippet || assertionErrorTypes.includes(normalizeErrorType(res));
        const responseForError = getResponseForError(res);
        const message = getErrorMessage({
Severity: Major
Found in lib/utils/socketChainHelper.js - About 4 hrs to fix

    Consider simplifying this complex logical expression.
    Open

        if (
        hasQuery &&
        !data.comparator &&
        !data.isClick &&
        !data.tap &&
    Severity: Critical
    Found in lib/utils/socketChainHelper.js - About 2 hrs to fix

      Avoid too many return statements within this function.
      Open

                      return;
      Severity: Major
      Found in lib/utils/socketChainHelper.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                    return;
        Severity: Major
        Found in lib/utils/socketChainHelper.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                          return fs.promises
                    .access(dir)
                    .catch(() => fs.promises.mkdir(dir))
                    .then(() => fs.promises.writeFile(data.fileName, res.buffer))
                    .catch(e => {
          Severity: Major
          Found in lib/utils/socketChainHelper.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                            return res.buffer;
            Severity: Major
            Found in lib/utils/socketChainHelper.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                              return res.buffer.toString('base64');
              Severity: Major
              Found in lib/utils/socketChainHelper.js - About 30 mins to fix

                There are no issues that match your filters.

                Category
                Status