SumOfUs/Champaign

View on GitHub
app/javascript/components/Braintree/BraintreeCardFields.js

Summary

Maintainability
D
1 day
Test Coverage

File BraintreeCardFields.js has 296 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import React, { Component } from 'react';
import { injectIntl, FormattedMessage } from 'react-intl';
import classnames from 'classnames';
import braintree from 'braintree-web';
import hostedFields from 'braintree-web/hosted-fields';
Severity: Minor
Found in app/javascript/components/Braintree/BraintreeCardFields.js - About 3 hrs to fix

    Function createHostedFields has 57 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      createHostedFields(client) {
        Promise.all([
          braintree.threeDSecure.create(
            {
              client: client,
    Severity: Major
    Found in app/javascript/components/Braintree/BraintreeCardFields.js - About 2 hrs to fix

      Function render has 48 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        render() {
          const prefix = 'BraintreeCardFields';
          const classNames = classnames({
            [prefix]: true,
            [`${prefix}--active`]: this.props.isActive,
      Severity: Minor
      Found in app/javascript/components/Braintree/BraintreeCardFields.js - About 1 hr to fix

        Function submit has 45 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          submit(event) {
            if (event) event.preventDefault();
            const donationAmount = this.props.amount;
            this.resetErrors();
        
        
        Severity: Minor
        Found in app/javascript/components/Braintree/BraintreeCardFields.js - About 1 hr to fix

          Function constructor has 44 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            constructor(props) {
              super(props);
              const lang = window.champaign.page.language_code;
              this.state = {
                hostedFields: null,
          Severity: Minor
          Found in app/javascript/components/Braintree/BraintreeCardFields.js - About 1 hr to fix

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                    number: Object.freeze({
                      selector: '#braintree-card-number',
                      placeholder: this.props.intl.formatMessage({
                        id: 'fundraiser.fields.number',
                        defaultMessage: 'Card number',
            Severity: Major
            Found in app/javascript/components/Braintree/BraintreeCardFields.js and 2 other locations - About 50 mins to fix
            app/javascript/components/Braintree/BraintreeCardFields.js on lines 39..45
            app/javascript/components/Braintree/BraintreeCardFields.js on lines 46..52

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 51.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                    cvv: Object.freeze({
                      selector: '#braintree-cvv',
                      placeholder: this.props.intl.formatMessage({
                        id: 'fundraiser.fields.cvv',
                        defaultMessage: 'CVV',
            Severity: Major
            Found in app/javascript/components/Braintree/BraintreeCardFields.js and 2 other locations - About 50 mins to fix
            app/javascript/components/Braintree/BraintreeCardFields.js on lines 32..38
            app/javascript/components/Braintree/BraintreeCardFields.js on lines 46..52

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 51.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                    expirationDate: Object.freeze({
                      selector: '#braintree-expiration-date',
                      placeholder: this.props.intl.formatMessage({
                        id: 'fundraiser.fields.expiration_format',
                        defaultMessage: 'MM/YY',
            Severity: Major
            Found in app/javascript/components/Braintree/BraintreeCardFields.js and 2 other locations - About 50 mins to fix
            app/javascript/components/Braintree/BraintreeCardFields.js on lines 32..38
            app/javascript/components/Braintree/BraintreeCardFields.js on lines 39..45

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 51.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status