SumOfUs/Champaign

View on GitHub
app/javascript/state/fundraiser/reducer.js

Summary

Maintainability
C
1 day
Test Coverage

File reducer.js has 356 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import { isEmpty, keys, pick, reduce } from 'lodash';
import ee from '../../shared/pub_sub';

import { isDirectDebitSupported } from '../../util/directDebitDecider';

Severity: Minor
Found in app/javascript/state/fundraiser/reducer.js - About 4 hrs to fix

    Avoid too many return statements within this function.
    Open

          return {
            ...state,
            recurring: action.payload,
            showDirectDebit,
            localPaymentTypes,
    Severity: Major
    Found in app/javascript/state/fundraiser/reducer.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

            return {
              ...state,
              ...featuredAmountState(preselectAmount, { donationBands, currency }),
              currency,
              donationBands,
      Severity: Major
      Found in app/javascript/state/fundraiser/reducer.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

              return {
                ...state,
                ...data,
                showDirectDebit,
                localPaymentTypes,
        Severity: Major
        Found in app/javascript/state/fundraiser/reducer.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                return {
                  ...state,
                  directDebitOnly: action.payload,
                  paymentTypes,
                  currentPaymentType,
          Severity: Major
          Found in app/javascript/state/fundraiser/reducer.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                  return {
                    ...state,
                    form,
                    formValues,
                    outstandingFields,
            Severity: Major
            Found in app/javascript/state/fundraiser/reducer.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                    return {
                      ...state,
                      currentPaymentType: safePaymentType(action.payload, state.paymentTypes),
                    };
              Severity: Major
              Found in app/javascript/state/fundraiser/reducer.js - About 30 mins to fix

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                      const localPaymentTypes = getLocalPaymentTypes({
                        country: state.form.country || state.formValues.country,
                        recurring: action.payload,
                        currency: state.currency,
                      });
                Severity: Major
                Found in app/javascript/state/fundraiser/reducer.js and 2 other locations - About 1 hr to fix
                app/javascript/state/fundraiser/reducer.js on lines 165..169
                app/javascript/state/fundraiser/reducer.js on lines 248..252

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 55.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                      const localPaymentTypes = getLocalPaymentTypes({
                        country: state.form.country || state.formValues.country,
                        recurring: data.recurring,
                        currency: state.currency,
                      });
                Severity: Major
                Found in app/javascript/state/fundraiser/reducer.js and 2 other locations - About 1 hr to fix
                app/javascript/state/fundraiser/reducer.js on lines 165..169
                app/javascript/state/fundraiser/reducer.js on lines 216..220

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 55.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                      const localPaymentTypes = getLocalPaymentTypes({
                        country: state.form.country || state.formValues.country,
                        recurring: action.payload,
                        currency: state.currency,
                      });
                Severity: Major
                Found in app/javascript/state/fundraiser/reducer.js and 2 other locations - About 1 hr to fix
                app/javascript/state/fundraiser/reducer.js on lines 216..220
                app/javascript/state/fundraiser/reducer.js on lines 248..252

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 55.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                      const showDirectDebit = isDirectDebitSupported({
                        country: state.form.country || state.formValues.country,
                        recurring: data.recurring,
                      });
                Severity: Minor
                Found in app/javascript/state/fundraiser/reducer.js and 1 other location - About 35 mins to fix
                app/javascript/state/fundraiser/reducer.js on lines 211..214

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 46.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                      const showDirectDebit = isDirectDebitSupported({
                        country: state.form.country || state.formValues.country,
                        recurring: action.payload,
                      });
                Severity: Minor
                Found in app/javascript/state/fundraiser/reducer.js and 1 other location - About 35 mins to fix
                app/javascript/state/fundraiser/reducer.js on lines 243..246

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 46.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status