Showing 157 of 338 total issues
Function constructor has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
constructor(options: IDonationsThermometerOptions) {
super(options);
if (!options.el) {
throw new Error(
'Donations Thermometer must be initialised with an element and a store.'- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method run has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def run
raise PaymentProcessor::Exceptions::CustomerNotFound unless @member.try(:customer)
# TODO: On the second attempt (if the member consents to duplicate donation), post with the same parameters
# but also params[:allow_duplicate] = true- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method plugin_refs has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def plugin_refs(ref: nil, depth: 0)
return [] if depth > 2
introspector = LiquidTagFinder.new(content)
plugin_names = introspector.plugin_names- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method update_page has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def update_page
return unless @params[:page]
plugins_before = @page.plugins
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function create has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
const create = async function(params) {
const inner = {};
inner.member_phone_number = params.memberPhoneNumber;
if (!!params.targetPhoneExtension)
inner.target_phone_extension = params.targetPhoneExtension;- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function showOneOffButton has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
let showOneOffButton = (recurringDonor, recurringDefault) => {
if (recurringDonor) {
return true;
} else {
if (recurringDefault === 'only_one_off') {- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function prefill has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
prefill() {
const data = {};
for (const field of this.props.fields) {
data[field.name] = this.props.formValues[field.name]
? this.props.formValues[field.name]- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method genuine_user? has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def genuine_user?
unless user.has_account?
return true if email_account_exist?(email)
log_error_message('Recaptcha: Failed, UserAccountNotExist, EmailAccountExistence: false', true)- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method deduplicate has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def deduplicate(values)
duplicates = values.group_by { |e| e }.select { |_k, v| v.size > 1 }.values.flatten
safe = values - duplicates
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method import has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def import
return false unless valid?
begin
funds = JSON.parse(File.read(file.tempfile))- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method validate_length has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def validate_length(value, form_element)
if form_element[:data_type] == 'text' && (value || []).size >= MAX_LENGTH[:TEXT]
@errors[form_element[:name]] << I18n.t('validation.is_invalid_length', length: MAX_LENGTH[:TEXT])
elsif form_element[:data_type] == 'paragraph' && (value || []).size >= MAX_LENGTH[:PARAGRAPH]
@errors[form_element[:name]] << I18n.t('validation.is_invalid_length', length: MAX_LENGTH[:PARAGRAPH])- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method valid? has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def valid?
super
if errors.present?
log_error_message('Recaptcha: VerificationInitiaizationFailed', true)- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method search has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def search
@queries.each_pair do |search_type, query|
next unless query.present?
case search_type.to_sym- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function updateSummaryRows has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
updateSummaryRows: function(data) {
// this only updates existing shares. new ones are appended by
// code in view/share/shares/create.js.erb, using rails UJS
$.get(`/api/pages/${data.id}/share-rows`, rows => {
_.each(rows, row => {- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method toggle_featured_link has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def toggle_featured_link(page)
method = page.featured? ? :delete : :post
klass = "glyphicon glyphicon-star#{'-empty' unless page.featured?}"
path = page.featured? ? featured_page_path(page) : featured_pages_path(id: page.id)- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method location has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def location
return @location if @location.blank?
country_code = if @member.try(:country) && @member.country.length == 2
@member.country- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function showOneOffButton has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
showOneOffButton() {
if (this.state.recurringDonor) {
return true;
} else {
if (this.state.recurringDefault === 'only_one_off') {- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"