Showing 13 of 15 total issues
Method update_from_zip has a Cognitive Complexity of 38 (exceeds 5 allowed). Consider refactoring. Open
def update_from_zip(zip_url, exercise_dir_name, course_dir_name, exercise, course)
zip = fetch_zip(zip_url)
output.puts "URL: #{zip_url}"
work_dir = Dir.pwd
to_dir = if Dir.pwd.chomp("/").split("/").last == exercise_dir_name- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
File client.rb has 350 lines of code (exceeds 250 allowed). Consider refactoring. Open
require 'rubygems'
require 'highline/import'
require 'json'
require 'faraday'
require 'yaml'Class Client has 32 methods (exceeds 20 allowed). Consider refactoring. Open
class Client
attr_accessor :courses, :config, :conn, :output, :input
def initialize(output=$stdout, input=$stdin)
@config = MyConfig.new
@output = outputMethod update_automatically_detected_project_from_zip has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring. Open
def update_automatically_detected_project_from_zip(zip_url, exercise_dir_name, course_dir_name, exercise, course)
zip = fetch_zip(exercise['zip_url'])
work_dir = Dir.pwd
to_dir = if Dir.pwd.chomp("/").split("/").last == exercise_dir_name
work_dir- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method update_from_zip has 40 lines of code (exceeds 25 allowed). Consider refactoring. Open
def update_from_zip(zip_url, exercise_dir_name, course_dir_name, exercise, course)
zip = fetch_zip(zip_url)
output.puts "URL: #{zip_url}"
work_dir = Dir.pwd
to_dir = if Dir.pwd.chomp("/").split("/").last == exercise_dir_nameMethod submit_exercise has 35 lines of code (exceeds 25 allowed). Consider refactoring. Open
def submit_exercise(*args)
# Initialize course and exercise names to identify exercise to submit (from json)
if args.count == 0 or args.all? { |arg| arg.start_with? "-" }
exercise_dir_name = current_directory_name
course_dir_name = previous_directory_nameMethod status has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring. Open
def status(submission_id_or_url)
url = (submission_id_or_url.include? "submissions") ? submission_id_or_url : "/submissions/#{submission_id_or_url}.json?api_version=5"
json = JSON.parse(@conn.get(url).body)
if json['status'] != 'processing'
puts "Status: #{json['status']}"- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method update_automatically_detected_project_from_zip has 31 lines of code (exceeds 25 allowed). Consider refactoring. Open
def update_automatically_detected_project_from_zip(zip_url, exercise_dir_name, course_dir_name, exercise, course)
zip = fetch_zip(exercise['zip_url'])
work_dir = Dir.pwd
to_dir = if Dir.pwd.chomp("/").split("/").last == exercise_dir_name
work_dirMethod submit_exercise has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
def submit_exercise(*args)
# Initialize course and exercise names to identify exercise to submit (from json)
if args.count == 0 or args.all? { |arg| arg.start_with? "-" }
exercise_dir_name = current_directory_name
course_dir_name = previous_directory_name- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method update_exercise has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
def update_exercise(exercise_dir_name=nil)
# Initialize course and exercise names to identify exercise to submit (from json)
is_universal = false
if exercise_dir_name.nil?
exercise_dir_name = current_directory_name- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method update_from_zip has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
def update_from_zip(zip_url, exercise_dir_name, course_dir_name, exercise, course)Method update_automatically_detected_project_from_zip has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
def update_automatically_detected_project_from_zip(zip_url, exercise_dir_name, course_dir_name, exercise, course)Method setup_client has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def setup_client
begin
@config.server_url ||= request_server_url
rescue
request_server_url- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"