Sign upLogin

TUBB/h5-imageviewer

View on GitHub
Star
src/imgListViewer.js

Summary

Maintainability
F
6 days
Test Coverage

Function registerViewerAlloyFinger has a Cognitive Complexity of 81 (exceeds 5 allowed). Consider refactoring.
Open

const registerViewerAlloyFinger = () => {
  const {
    pageDampingFactor,
    imgMoveFactor,
    pageThreshold,
Severity: Minor
Found in src/imgListViewer.js - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File imgListViewer.js has 514 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import './main.less'
import imageLoaded from './utils/image_loaded'
import Transform from './utils/transform'
import To from './utils/to'
import ease from './utils/ease'
Severity: Major
Found in src/imgListViewer.js - About 1 day to fix

    Function registerViewerAlloyFinger has 121 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    const registerViewerAlloyFinger = () => {
  const {
    pageDampingFactor,
    imgMoveFactor,
    pageThreshold,
    Severity: Major
    Found in src/imgListViewer.js - About 4 hrs to fix

      Function setCurrentPage has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
      Open

      export const setCurrentPage = pageIndex => {
  if (viewerData === null 
    || pageIndex < 0 
    || pageIndex > viewerData.imgList.length - 1) {
    return
      Severity: Minor
      Found in src/imgListViewer.js - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function setCurrentPage has 57 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      export const setCurrentPage = pageIndex => {
  if (viewerData === null 
    || pageIndex < 0 
    || pageIndex > viewerData.imgList.length - 1) {
    return
      Severity: Major
      Found in src/imgListViewer.js - About 2 hrs to fix

        Function pressMoveListener has 44 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            pressMoveListener: evt => {
      const currImgDom = getCurrImgDom()
      if (!evt || !currImgDom) return
      const currPageTranslateStart = currPage * window.innerWidth
      const { scaleX, width, translateX } = currImgDom
        Severity: Minor
        Found in src/imgListViewer.js - About 1 hr to fix

          Function initParams has 44 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          const initParams = (imgList, options, screenRotation, cachedCurrPage) => {
  let wrapOptions = {}
  if (options) wrapOptions = { ...options }
  const {
    defaultPageIndex = 0,
          Severity: Minor
          Found in src/imgListViewer.js - About 1 hr to fix

            Function replaceImgDom has 40 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            const replaceImgDom = (prevPage) => {
  if (viewerData === null) return 
  const { imgList, options: { limit } } = viewerData
  const lastIndex = imgList.length - 1
  if (currPage === 0 ||
            Severity: Minor
            Found in src/imgListViewer.js - About 1 hr to fix

              Function handleImgDoms has 35 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              const handleImgDoms = () => {
  let docfrag = document.createDocumentFragment()
  const { imgList } = viewerData
  const lastIndex = imgList.length - 1
  const { limit } = viewerData.options
              Severity: Minor
              Found in src/imgListViewer.js - About 1 hr to fix

                Function scrollToPage has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                Open

                const scrollToPage = (dom, targetPage, prevPage) => {
  // page changed, so we reset current page's translateX、scaleX、scaleY
  if (targetPage !== prevPage) {
    viewerData.options.onPageChanged(targetPage)
    const { translateX, translateY, scaleX, scaleY } = dom
                Severity: Minor
                Found in src/imgListViewer.js - About 55 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Avoid deeply nested control flow statements.
                Open

                              if (Math.abs(panelDom.translateX) > currPageTranslateStart) {
                const panelReturnDis = panelTranslateX
                if (Math.abs(panelReturnDis) < currPageTranslateStart) {
                  panelDom.translateX = -currPageTranslateStart
                } else {
                Severity: Major
                Found in src/imgListViewer.js - About 45 mins to fix

                  Avoid deeply nested control flow statements.
                  Open

                                if (Math.abs(panelDom.translateX) < currPageTranslateStart) {
                const panelReturnDis = panelTranslateX
                if (Math.abs(panelReturnDis) > currPageTranslateStart) {
                  panelDom.translateX = -currPageTranslateStart
                } else {
                  Severity: Major
                  Found in src/imgListViewer.js - About 45 mins to fix

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                                if (deltaX > 0) { // move to right
              if (Math.abs(panelDom.translateX) > currPageTranslateStart) {
                const panelReturnDis = panelTranslateX
                if (Math.abs(panelReturnDis) < currPageTranslateStart) {
                  panelDom.translateX = -currPageTranslateStart
                    Severity: Major
                    Found in src/imgListViewer.js and 1 other location - About 3 hrs to fix
                    src/imgListViewer.js on lines 230..241

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 97.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                                } else { // move to left
              if (Math.abs(panelDom.translateX) < currPageTranslateStart) {
                const panelReturnDis = panelTranslateX
                if (Math.abs(panelReturnDis) > currPageTranslateStart) {
                  panelDom.translateX = -currPageTranslateStart
                    Severity: Major
                    Found in src/imgListViewer.js and 1 other location - About 3 hrs to fix
                    src/imgListViewer.js on lines 219..230

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 97.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                    const resetImgDom = (imgDom, w) => {
  let imgWidth = 0
  if (w > window.innerWidth) {
    imgWidth = window.innerWidth
  } else {
                    Severity: Major
                    Found in src/imgListViewer.js and 1 other location - About 2 hrs to fix
                    src/imgViewer.js on lines 111..120

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 92.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                    export const hideImgListViewer = (notifyUser = true) => {
  if (viewerData) {
    if (notifyUser) {
      viewerData.options.onViewerHideListener()
    }
                    Severity: Major
                    Found in src/imgListViewer.js and 1 other location - About 1 hr to fix
                    src/imgViewer.js on lines 61..69

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 59.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status