Sign upLogin

Tapjoy/pagerduty_utils

View on GitHub
Star

Showing 2 of 4 total issues

Method initialize has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

      def initialize
        config_file = "#{ENV['PAGERDUTY_CONFIG_DIR'] ? ENV['PAGERDUTY_CONFIG_DIR'] + 'pgconnect.yml' : ENV['HOME'] + '/.pgutils/pgconnect.yaml'}"
        pg_conn = YAML.load_file(config_file) if File.readable?(config_file)

        @AUTH_HEADER = {
Severity: Minor
Found in lib/tapjoy/pagerduty/base.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

          return integration_api_url + '/create_event.json'
Severity: Major
Found in lib/tapjoy/pagerduty/base.rb - About 30 mins to fix
    Severity
    Category
    Status
    Source
    Language