Sign upLogin

TargetProcess/tauCharts

View on GitHub
Star
src/utils/d3-labeler.js

Summary

Maintainability
F
4 days
Test Coverage

Function d3Labeler has a Cognitive Complexity of 77 (exceeds 5 allowed). Consider refactoring.
Open

var d3Labeler = function () {
    var lab = [],
        anc = [],
        w = 1, // box width
        h = 1, // box width
Severity: Minor
Found in src/utils/d3-labeler.js - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function d3Labeler has 228 lines of code (exceeds 25 allowed). Consider refactoring.
Open

var d3Labeler = function () {
    var lab = [],
        anc = [],
        w = 1, // box width
        h = 1, // box width
Severity: Major
Found in src/utils/d3-labeler.js - About 1 day to fix

    Function energy has 51 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        var energy = function (index) {
        // energy function, tailored for label placement

        var m = lab.length,
            ener = 0,
    Severity: Major
    Found in src/utils/d3-labeler.js - About 2 hrs to fix

      Function mcrotate has 44 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          var mcrotate = function (currT) {
        // Monte Carlo rotation move

        // select a random label
        var i = Math.floor(Math.random() * lab.length);
      Severity: Minor
      Found in src/utils/d3-labeler.js - About 1 hr to fix

        Function mcmove has 37 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            var mcmove = function (currT) {
        // Monte Carlo translation move

        // select a random label
        var i = Math.floor(Math.random() * lab.length);
        Severity: Minor
        Found in src/utils/d3-labeler.js - About 1 hr to fix

          Function intersect has 8 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              var intersect = function (x1, x2, x3, x4, y1, y2, y3, y4) {
          Severity: Major
          Found in src/utils/d3-labeler.js - About 1 hr to fix

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                    if (Math.random() < Math.exp(-delta_energy / currT)) {
            acc += 1;
        } else {
            // move back to old coordinates
            lab[i].x = x_old;
            Severity: Major
            Found in src/utils/d3-labeler.js and 1 other location - About 2 hrs to fix
            src/utils/d3-labeler.js on lines 214..221

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 82.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                    if (Math.random() < Math.exp(-delta_energy / currT)) {
            acc += 1;
        } else {
            // move back to old coordinates
            lab[i].x = x_old;
            Severity: Major
            Found in src/utils/d3-labeler.js and 1 other location - About 2 hrs to fix
            src/utils/d3-labeler.js on lines 142..149

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 82.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

                labeler.width = function (x) {
        // users insert graph width
        if (!arguments.length) {
            return w;
        }
            Severity: Major
            Found in src/utils/d3-labeler.js and 3 other locations - About 30 mins to fix
            src/utils/d3-labeler.js on lines 277..284
            src/utils/d3-labeler.js on lines 286..293
            src/utils/d3-labeler.js on lines 295..302

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 45.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

                labeler.label = function (x) {
        // users insert label positions
        if (!arguments.length) {
            return lab;
        }
            Severity: Major
            Found in src/utils/d3-labeler.js and 3 other locations - About 30 mins to fix
            src/utils/d3-labeler.js on lines 268..275
            src/utils/d3-labeler.js on lines 277..284
            src/utils/d3-labeler.js on lines 295..302

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 45.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

                labeler.height = function (x) {
        // users insert graph height
        if (!arguments.length) {
            return h;
        }
            Severity: Major
            Found in src/utils/d3-labeler.js and 3 other locations - About 30 mins to fix
            src/utils/d3-labeler.js on lines 268..275
            src/utils/d3-labeler.js on lines 286..293
            src/utils/d3-labeler.js on lines 295..302

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 45.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

                labeler.anchor = function (x) {
        // users insert anchor positions
        if (!arguments.length) {
            return anc;
        }
            Severity: Major
            Found in src/utils/d3-labeler.js and 3 other locations - About 30 mins to fix
            src/utils/d3-labeler.js on lines 268..275
            src/utils/d3-labeler.js on lines 277..284
            src/utils/d3-labeler.js on lines 286..293

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 45.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status