Terralego/django-terra-geocrud

View on GitHub

Showing 14 of 34 total issues

File models.py has 363 lines of code (exceeds 250 allowed). Consider refactoring.
Open

from copy import deepcopy

from django.contrib.gis.db.models import Extent
from django.core.exceptions import ValidationError
from django.db.models import FloatField, CharField, IntegerField
Severity: Minor
Found in terra_geocrud/models.py - About 4 hrs to fix

    Function store_feature_files has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

    def store_feature_files(feature, old_properties=None):
        """ Handle base64 encoded files to django storage. Use fake base64 to compatibility with react-json-schema """
        fake_content = 'R0lGODlhAQABAIAAAAUEBAAAACwAAAAAAQABAAACAkQBADs='
        files_properties = get_files_properties(feature)
        if files_properties:
    Severity: Minor
    Found in terra_geocrud/properties/files.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function get_data has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        def get_data(self, context):
            final_data = self.data
    
            width = 1024 if not final_data['width'] else final_data['width'].resolve(context)
            height = 512 if not final_data['height'] else final_data['height'].resolve(context)
    Severity: Minor
    Found in terra_geocrud/templatetags/map_tags.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function clean_properties_not_in_schema_or_null has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

    def clean_properties_not_in_schema_or_null(crud_view):
        """ Clean properties not in layer schema to avoid schema validation """
        layer = crud_view.layer
        features = layer.features.all()
        if layer.schema:
    Severity: Minor
    Found in terra_geocrud/properties/schema.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function grouped_ui_schema has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        def grouped_ui_schema(self):
            """
            Original ui_schema is recomposed with grouped properties
            """
            ui_schema = deepcopy(self.ui_schema)
    Severity: Minor
    Found in terra_geocrud/properties/schema.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function full_json_schema has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        def full_json_schema(self):
            """
            Generate full json schema by adding custom conf to store schema.
            All keys defined in json_schema column are kept if already present.
            """
    Severity: Minor
    Found in terra_geocrud/models.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function clean has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        def clean(self):
            if self.layer and not self.layer.routable:
                raise ValidationError(
                    _("You should define layer with a routable layer")
                )
    Severity: Minor
    Found in terra_geocrud/models.py - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function get_style_base_layer has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def get_style_base_layer(self, base_layer):
            try:
                map_base_layer = MapBaseLayer.objects.get(slug=base_layer)
            except MapBaseLayer.DoesNotExist:
                logger.warning(f"MapBaseLayer with slug '{base_layer}' was not found. Try to get another map base layer.")
    Severity: Minor
    Found in terra_geocrud/templatetags/map_tags.py - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function grouped_form_schema has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        def grouped_form_schema(self):
            original_schema = deepcopy(self.layer.schema)
            generated_schema = deepcopy(original_schema)
            groups = self.feature_display_groups.all()
            generated_schema['properties'] = {}
    Severity: Minor
    Found in terra_geocrud/properties/schema.py - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function get_style has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        def get_style(self, feature, feature_included, extras_included, base_layer):
            style_map = self.get_style_base_layer(base_layer)
            view = feature.layer.crud_view
            primary_layer = {}
            if feature_included:
    Severity: Minor
    Found in terra_geocrud/templatetags/map_tags.py - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function sync_properties_relations_destination has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

    def sync_properties_relations_destination(feature, update_relations=False):
        for relation_destination in feature.layer.relations_as_destination.all():
            for feature in relation_destination.origin.features.all():
                if update_relations:
                    feature.sync_relations(relation_destination.pk)
    Severity: Minor
    Found in terra_geocrud/tasks.py - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function generate_thumbnail_from_image has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

    def generate_thumbnail_from_image(value, data, data_type):
        # generate / get thumbnail for image
        if not value:
            return data, data_type
        try:
    Severity: Minor
    Found in terra_geocrud/properties/utils.py - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function validate_properties has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def validate_properties(self, data):
            new_data = deepcopy(data)
            # ungroup properties
            for key, value in new_data.items():
                if isinstance(value, dict):
    Severity: Minor
    Found in terra_geocrud/serializers.py - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function get_map_layers has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def get_map_layers(self, obj):
            data = [{
                'title': obj.name,
                # TODO: Add slugify to be consistent with relations
                'id_layer_vt': obj.layer.name,
    Severity: Minor
    Found in terra_geocrud/serializers.py - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language