Sign upLogin

TheClimateCorporation/iron_hide

View on GitHub
Star

Showing 3 of 3 total issues

Method test has 43 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def test
    num       = @num
    expensive = @expensive

    [ User, Resource ].each do |klass|
Severity: Minor
Found in benchmark/benchmark.rb - About 1 hr to fix

    Method evaluate has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        def evaluate(expression, user, resource)
      Array(expression).flat_map do |el|
        if expression?(el)
          cache.fetch(el) {
            type, *ary  = el.split('::')
    Severity: Minor
    Found in lib/iron_hide/condition.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method allow? has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def self.allow?(user, action, resource)
      find(user, action, resource).inject(false) do |rval, rule|
        # For an explicit DENY, stop evaluating, and return false
        rval = false and break if rule.explicit_deny?
    Severity: Minor
    Found in lib/iron_hide/rule.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language