Sign upLogin

ThinkDeepTech/thinkdeep

View on GitHub
Star
packages/deep-microservice-collection/src/collection-service.js

Summary

Maintainability
C
1 day
Test Coverage

Function constructor has 86 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  constructor(
    tweetStore,
    economicEntityMemo,
    commander,
    admin,
Severity: Major
Found in packages/deep-microservice-collection/src/collection-service.js - About 3 hrs to fix

    File collection-service.js has 255 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import {
  EconomicEntityFactory,
  EconomicEntityType,
  validEconomicEntities,
} from '@thinkdeep/model';
    Severity: Minor
    Found in packages/deep-microservice-collection/src/collection-service.js - About 2 hrs to fix

      Function _commands has 44 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        _commands(economicEntity) {
    if (!validEconomicEntities([economicEntity])) {
      throw new Error(
        `Economic entity was invalid. Received: ${economicEntity.toString()}`
      );
      Severity: Minor
      Found in packages/deep-microservice-collection/src/collection-service.js - About 1 hr to fix

        Function _handleTweetsFetched has 37 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          async _handleTweetsFetched(utcDateTime, economicEntity, tweets) {
    if (!validDate(utcDateTime)) {
      throw new Error(`${utcDateTime} is an invalid date.`);
    }
        Severity: Minor
        Found in packages/deep-microservice-collection/src/collection-service.js - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              try {
      await this._admin.createTopics({
        /**
         * NOTE: If you don't wait for leaders the system throws an error when trying to write to the topic if a leader
         * hasn't been selected.
          Severity: Major
          Found in packages/deep-microservice-collection/src/collection-service.js and 1 other location - About 1 hr to fix
          packages/deep-microservice-analysis/src/analysis-service.js on lines 290..309

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 69.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status