Showing 29 of 520 total issues
File MainActivity.java
has 624 lines of code (exceeds 250 allowed). Consider refactoring. Open
package puscas.mobilertapp;
import android.app.Activity;
import android.app.ActivityManager;
import android.content.ActivityNotFoundException;
File MainRenderer.java
has 474 lines of code (exceeds 250 allowed). Consider refactoring. Open
package puscas.mobilertapp;
import android.app.ActivityManager;
import android.graphics.Bitmap;
import android.graphics.Color;
MainRenderer
has 40 methods (exceeds 20 allowed). Consider refactoring. Open
public final class MainRenderer implements GLSurfaceView.Renderer {
/**
* Logger for this class.
*/
MainActivity
has 37 methods (exceeds 20 allowed). Consider refactoring. Open
public final class MainActivity extends Activity {
/**
* Logger for this class.
*/
Method onActivityResult
has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring. Open
@Override
protected void onActivityResult(final int requestCode,
final int resultCode,
@Nullable final Intent data) {
super.onActivityResult(requestCode, resultCode, data);
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
File DrawView.java
has 251 lines of code (exceeds 250 allowed). Consider refactoring. Open
package puscas.mobilertapp;
import android.app.Activity;
import android.app.ActivityManager;
import android.content.Context;
Method onActivityResult
has 44 lines of code (exceeds 25 allowed). Consider refactoring. Open
@Override
protected void onActivityResult(final int requestCode,
final int resultCode,
@Nullable final Intent data) {
super.onActivityResult(requestCode, resultCode, data);
Method isPathReadable
has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring. Open
private static boolean isPathReadable(final File file) {
final boolean readable = file.setReadable(true);
if (!file.canRead() && !readable) {
final File parentFile = file.getParentFile();
if (parentFile == null) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method getPathFromFile
has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring. Open
@NonNull
private String getPathFromFile(@NonNull final Uri uri) {
logger.info("Parsing path:" + Arrays.toString(uri.getPathSegments().toArray()));
validatePathIsAccessible(uri);
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method renderScene
has 30 lines of code (exceeds 25 allowed). Consider refactoring. Open
synchronized void renderScene(@NonNull final Config config) {
logger.info(ConstantsMethods.RENDER_SCENE);
MainActivity.resetErrno();
stopDrawing();
Method perform
has 30 lines of code (exceeds 25 allowed). Consider refactoring. Open
@Override
public void perform(@NonNull final UiController uiController, @NonNull final View view) {
final String methodName = Thread.currentThread().getStackTrace()[2].getMethodName();
logger.info(methodName);
Method initializePickerResolutions
has 29 lines of code (exceeds 25 allowed). Consider refactoring. Open
private void initializePickerResolutions(final int pickerSizes) {
logger.info("initializePickerResolutions start");
final int maxSizes = 9;
this.pickerResolutions.setMinValue(1);
this.pickerResolutions.setMaxValue(maxSizes - 1);
Method setupRenderer
has 29 lines of code (exceeds 25 allowed). Consider refactoring. Open
private void setupRenderer(final TextView textView, final Button renderButton) {
logger.info("setupRenderer start");
this.drawView.setVisibility(View.INVISIBLE);
this.drawView.setEGLContextClientVersion(MyEglContextFactory.EGL_CONTEXT_CLIENT_VERSION);
Method loadShader
has 28 lines of code (exceeds 25 allowed). Consider refactoring. Open
@VisibleForTesting
public static int loadShader(final int shaderType,
@NonNull final String source) {
logger.info("loadShader");
final int shader = UtilsGL.run(() -> GLES20.glCreateShader(shaderType));
Method waitUntil
has 28 lines of code (exceeds 25 allowed). Consider refactoring. Open
public static void waitUntil(@NonNull final MainActivity activity, final String expectedButtonText, final State... expectedStates) throws TimeoutException {
logger.info("waitUntil start, expected button: " + expectedButtonText + ", expected state(s): " + Arrays.toString(expectedStates));
final AtomicBoolean done = new AtomicBoolean(false);
/*
Only advance 1 second at a time, otherwise the following error can appear:
Method getPathFromFile
has 28 lines of code (exceeds 25 allowed). Consider refactoring. Open
@NonNull
private String getPathFromFile(@NonNull final Uri uri) {
logger.info("Parsing path:" + Arrays.toString(uri.getPathSegments().toArray()));
validatePathIsAccessible(uri);
Method createConfigFromUI
has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
@NonNull
private Config createConfigFromUI(@NonNull final String scenePath) {
final Pair<Integer, Integer> resolution =
Utils.getResolutionFromPicker(this.pickerResolutions);
Method readFile
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
private void readFile(@NonNull final Uri uri) {
logger.info("readFile");
final List<String> allowedPaths = List.of(Environment.getExternalStorageDirectory().getPath(), "/data/local/tmp/", "/storage/");
final boolean isAllowedPath;
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O) {
Method cleanStoragePath
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
@NonNull
public static String cleanStoragePath(@NonNull final String storagePath) {
String storagePathCleaned = storagePath;
// Remove Android path
Method onDrawFrame
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
@Override
public void onDrawFrame(@NonNull final GL10 gl) {
logger.info("onDrawFrame");
// Reset OpenGL frame buffer before drawing the new frame.