Sign upLogin

TianLiangZhou/shrimp-wechat-sdk

View on GitHub
Star

Showing 24 of 26 total issues

File ShrimpWechat.php has 308 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * Created by PhpStorm.
 * User: zhoutianliang
 * Date: 2017/5/3
Severity: Minor
Found in src/ShrimpWechat.php - About 3 hrs to fix

    ShrimpWechat has 26 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class ShrimpWechat
{
    const VERSION = 'v2.0.0';

    /**
    Severity: Minor
    Found in src/ShrimpWechat.php - About 3 hrs to fix

      File Material.php has 284 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      <?php

declare(strict_types=1);

namespace Shrimp\Api;
      Severity: Minor
      Found in src/Api/Material.php - About 2 hrs to fix

        File MimeType.php has 282 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        <?php

declare(strict_types=1);

namespace Shrimp\File;
        Severity: Minor
        Found in src/File/MimeType.php - About 2 hrs to fix

          Function uploadFileChecked has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
          Open

              private function uploadFileChecked(MediaFile $files, $type = null)
    {
        /**
         * @var File $file
         */
          Severity: Minor
          Found in src/Api/Material.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method create has 35 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function create(string $type, array $baseInfo, $exclusive, array $advanceInfo = [])
    {
        $uri = $this->format('card/create');
        $property = [
            'base_info' => $baseInfo,
          Severity: Minor
          Found in src/Api/Card.php - About 1 hr to fix

            Method __toString has 34 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function __toString()
    {
        // TODO: Implement __toString() method.
        if (!is_array($this->content)) {
            return "success";
            Severity: Minor
            Found in src/Response/NewsResponse.php - About 1 hr to fix

              Method add has 33 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function add(MediaFile $files, $type = null, array $parameters = [])
    {
        try {
            list($file, $type) = $this->uploadFileChecked($files, $type);
        } catch (Exception $e) {
              Severity: Minor
              Found in src/Api/Material.php - About 1 hr to fix

                Method moduleFactory has 31 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    private function moduleFactory($name)
    {
        $module = null;
        switch ($name) {
            case 'menu':
                Severity: Minor
                Found in src/ShrimpWechat.php - About 1 hr to fix

                  Method mediaUploadImg has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function mediaUploadImg(MediaFile $files)
    {
        $response = [];
        foreach ($files as $file) {
            $ext = $file->getExtName();
                  Severity: Minor
                  Found in src/Api/Material.php - About 1 hr to fix

                    Method uploadFileChecked has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        private function uploadFileChecked(MediaFile $files, $type = null)
    {
        /**
         * @var File $file
         */
                    Severity: Minor
                    Found in src/Api/Material.php - About 1 hr to fix

                      Function normalize has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                      Open

                          protected static function normalize($obj)
    {
        $result = null;

        if (is_object($obj)) {
                      Severity: Minor
                      Found in src/Support/Xml.php - About 1 hr to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function moduleFactory has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                      Open

                          private function moduleFactory($name)
    {
        $module = null;
        switch ($name) {
            case 'menu':
                      Severity: Minor
                      Found in src/ShrimpWechat.php - About 1 hr to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Method create has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          public function create($content, $expire = 0)
    {
        $string = 'scene_str';
        $name = 'STR_SCENE';
        if (is_numeric($content)) {
                      Severity: Minor
                      Found in src/Api/Qrcode.php - About 1 hr to fix

                        Method __toString has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            public function __toString()
    {
        // TODO: Implement __toString() method.
        $mediaId = $this->content;
        $title = $description = $url = $hqUrl = '';
                        Severity: Minor
                        Found in src/Response/MusicResponse.php - About 1 hr to fix

                          Function mediaUploadImg has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                          Open

                              public function mediaUploadImg(MediaFile $files)
    {
        $response = [];
        foreach ($files as $file) {
            $ext = $file->getExtName();
                          Severity: Minor
                          Found in src/Api/Material.php - About 55 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Function setResponse has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                          Open

                              public function setResponse($response)
    {
        if ($response instanceof Response) {
            $this->response = $response;
        }
                          Severity: Minor
                          Found in src/Event/ResponseEvent.php - About 45 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Function data2Xml has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                          Open

                              protected static function data2Xml($data, $item = 'item', $id = 'id')
    {
        $xml = $attr = '';

        foreach ($data as $key => $val) {
                          Severity: Minor
                          Found in src/Support/Xml.php - About 45 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Consider simplifying this complex logical expression.
                          Open

                                  if (empty($article['title']) ||
            empty($article['content']) ||
            empty($article['content_source_url']) ||
            empty($article['thumb_media_id']) ||
            empty($article['author']) ||
                          Severity: Major
                          Found in src/Api/Material.php - About 40 mins to fix

                            Method build has 5 arguments (exceeds 4 allowed). Consider refactoring.
                            Open

                                    $data,
        $root = 'xml',
        $item = 'item',
        $attr = '',
        $id = 'id'
                            Severity: Minor
                            Found in src/Support/Xml.php - About 35 mins to fix
                              Severity
                              Category
                              Status
                              Source
                              Language