Sign upLogin

Ticketfly/ember-ticketfly-accordion

View on GitHub
Star

Showing 3 of 11 total issues

File ember.d.ts has 910 lines of code (exceeds 250 allowed). Consider refactoring.
Open

interface DOMElement {}
interface Promise<T> {}
declare class Registry {}
declare class Transition {}
declare namespace Handlebars { class SafeString {} }
Severity: Major
Found in typings/ember/ember.d.ts - About 2 days to fix

    Function exports has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    module.exports = function(defaults) {
  var app = new EmberAddon(defaults, {
    // Add options here
    postcssOptions: {
      compile: {
    Severity: Minor
    Found in ember-cli-build.js - About 1 hr to fix

      Function _onPanelSelection has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          _onPanelSelection(panel) {
      const panels = get(this, 'panels');
      const indexOfSelected = panels.indexOf(panel);
      const shouldExpand = !get(panel, 'isExpanded');
      const isAnimatable = get(this, 'isAnimatable');
      Severity: Minor
      Found in addon/components/tf-accordion.js - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language