TikiWiki/tiki-manager

View on GitHub

Showing 332 of 2,142 total issues

Method configure has 79 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function configure()
    {
        parent::configure();

        $this
Severity: Major
Found in src/Command/SetupCloneManagerCommand.php - About 3 hrs to fix

    Function cleanup has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
    Open

        public static function cleanup($instanceId, $instanceName, $maxBackups = 0)
        {
            $backup_directory = "{$instanceId}-{$instanceName}";
    
            $files = glob($_ENV['ARCHIVE_FOLDER'] . "/$backup_directory" . '/*.tar.bz2');
    Severity: Minor
    Found in src/Libs/Helpers/Archive.php - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method execute has 76 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function execute(InputInterface $input, OutputInterface $output)
        {
            $maxBackups = $input->getOption('max-backups') ?: Environment::get('DEFAULT_MAX_BACKUPS', 0);
            if (isset($maxBackups) && filter_var($maxBackups, FILTER_VALIDATE_INT) === false) {
                $this->io->error('Max number of backups to keep by instance is not a number');
    Severity: Major
    Found in src/Command/BackupInstanceCommand.php - About 3 hrs to fix

      Method readManifest has 76 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function readManifest($manifestPath)
          {
              $differentInstance = $this->instance->getId() != $this->getSourceInstance()->getId();
      
              $skipPathCheck = ($this->allowCommonParents < 0) || (count(explode('/', $this->instance->webroot)) < $this->allowCommonParents);
      Severity: Major
      Found in src/Application/Restore.php - About 3 hrs to fix

        Command has 26 functions (exceeds 20 allowed). Consider refactoring.
        Open

        class Command
        {
            private $args;
            private $command;
            private $host;
        Severity: Minor
        Found in src/Libs/Host/Command.php - About 3 hrs to fix

          Method configure has 73 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              protected function configure()
              {
                  parent::configure();
          
                  $this
          Severity: Major
          Found in src/Command/UpdateInstanceCommand.php - About 2 hrs to fix

            Method execute has 73 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                protected function execute(InputInterface $input, OutputInterface $output)
                {
                    $instances = CommandHelper::getInstances('no-tiki');
                    $instancesInfo = CommandHelper::getInstancesInfo($instances);
            
            
            Severity: Major
            Found in src/Command/RestoreInstanceCommand.php - About 2 hrs to fix

              Function execute has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
              Open

                  protected function execute(InputInterface $input, OutputInterface $output)
                  {
                      $instanceId = $input->getOption('instance');
                      $instance = Instance::getInstance($instanceId);
              
              
              Severity: Minor
              Found in src/Command/CheckoutCommand.php - About 2 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function execute has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
              Open

                  protected function execute(InputInterface $input, OutputInterface $output)
                  {
                      $helper = $this->getHelper('question');
                      $status = $input->getArgument('status');
                      $instancesOption = $input->getOption('instances');
              Severity: Minor
              Found in src/Command/MaintenanceInstanceCommand.php - About 2 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method execute has 71 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  protected function execute(InputInterface $input, OutputInterface $output)
                  {
                      $email = $input->getOption('email');
              
                      if (empty($email) || !filter_var($email, FILTER_VALIDATE_EMAIL)) {
              Severity: Major
              Found in src/Command/WatchInstanceCommand.php - About 2 hrs to fix

                FTP has 25 functions (exceeds 20 allowed). Consider refactoring.
                Open

                class FTP extends Access implements Mountable
                {
                    private $lastMount;
                
                    public function __construct(Instance $instance)
                Severity: Minor
                Found in src/Access/FTP.php - About 2 hrs to fix

                  VersionControlSystem has 25 functions (exceeds 20 allowed). Consider refactoring.
                  Open

                  abstract class VersionControlSystem implements LoggerAwareInterface
                  {
                      use LoggerAwareTrait;
                  
                      protected $command;
                  Severity: Minor
                  Found in src/Libs/VersionControl/VersionControlSystem.php - About 2 hrs to fix

                    Svn has 25 functions (exceeds 20 allowed). Consider refactoring.
                    Open

                    class Svn extends VersionControlSystem
                    {
                        /*
                         * @var string
                         */
                    Severity: Minor
                    Found in src/Libs/VersionControl/Svn.php - About 2 hrs to fix

                      Method interact has 69 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          protected function interact(InputInterface $input, OutputInterface $output)
                          {
                              $instances = CommandHelper::getInstances('tiki');
                              $instances = array_filter($instances, function ($instance) {
                                  return $instance->vcs_type == 'git';
                      Severity: Major
                      Found in src/Command/CheckoutCommand.php - About 2 hrs to fix

                        Function fixPermissions has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
                        Open

                            public function fixPermissions()
                            {
                                $instance = $this->instance;
                                $access = $instance->getBestAccess('scripting');
                        
                        
                        Severity: Minor
                        Found in src/Application/Tiki.php - About 2 hrs to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        File UpdateInstanceCommand.php has 281 lines of code (exceeds 250 allowed). Consider refactoring.
                        Open

                        <?php
                        /**
                         * @copyright (c) Copyright by authors of the Tiki Manager Project. All Rights Reserved.
                         *     See copyright.txt for details and a complete list of authors.
                         * @licence Licensed under the GNU LESSER GENERAL PUBLIC LICENSE. See LICENSE for details.
                        Severity: Minor
                        Found in src/Command/UpdateInstanceCommand.php - About 2 hrs to fix

                          Method applyPatch has 68 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                              public function applyPatch(Patch $patch, $options)
                              {
                                  $access = $this->instance->getBestAccess('scripting');
                                  $vcsType = $this->vcs_instance->getIdentifier();
                                  $can_patch = $access->hasExecutable('patch');
                          Severity: Major
                          Found in src/Application/Tiki.php - About 2 hrs to fix

                            Method execute has 67 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                                protected function execute(InputInterface $input, OutputInterface $output)
                                {
                                    $instanceId = $input->getOption('instance');
                                    $instance = Instance::getInstance($instanceId);
                            
                            
                            Severity: Major
                            Found in src/Command/CheckoutCommand.php - About 2 hrs to fix

                              CommandHelper has 24 functions (exceeds 20 allowed). Consider refactoring.
                              Open

                              class CommandHelper
                              {
                                  /**
                                   * Get information from Instance Object
                                   *
                              Severity: Minor
                              Found in src/Command/Helper/CommandHelper.php - About 2 hrs to fix

                                Database has 24 functions (exceeds 20 allowed). Consider refactoring.
                                Open

                                class Database
                                {
                                    /** @var Instance */
                                    private $instance;
                                    private $access;
                                Severity: Minor
                                Found in src/Libs/Database/Database.php - About 2 hrs to fix
                                  Severity
                                  Category
                                  Status
                                  Source
                                  Language