File video2commons.js
has 821 lines of code (exceeds 250 allowed). Consider refactoring. Open
/* globals nunjucks: false, io: false, Qs: false */
( function ( $ ) {
'use strict';
var config = window.config,
Function processInput
has 100 lines of code (exceeds 25 allowed). Consider refactoring. Open
processInput: function ( button ) {
var resolved = $.when(); // A resolved jQuery promise
var deferred;
switch ( newTaskData.step ) {
Function updateTask
has 71 lines of code (exceeds 25 allowed). Consider refactoring. Open
updateTask: function ( val ) {
var table = $( '#tasktable > tbody' );
var id = 'task-' + val.id,
$row = $( '#' + id );
Function setupAddTaskDialog
has 63 lines of code (exceeds 25 allowed). Consider refactoring. Open
setupAddTaskDialog: function () {
switch ( newTaskData.step ) {
case 'source':
$addTaskDialog.find( '.modal-body' )
.html( nunjucksEnv.render( 'sourceForm.html' ) );
Function initUpload
has 61 lines of code (exceeds 25 allowed). Consider refactoring. Open
initUpload: function () {
var deferred;
window.jqXHR = $addTaskDialog.find( '#fileupload' ).fileupload( {
dataType: 'json',
Function setupTaskRow
has 54 lines of code (exceeds 25 allowed). Consider refactoring. Open
setupTaskRow: function ( $row, id, status ) {
switch ( status ) {
case 'progress':
/* eslint-disable indent */
$row.append( $( '<td />' )
Function reactivatePrevNextButtons
has 39 lines of code (exceeds 25 allowed). Consider refactoring. Open
reactivatePrevNextButtons: function () {
$addTaskDialog.find( '#dialog-spinner' )
.hide();
switch ( newTaskData.step ) {
case 'source':
Function checkStatusSocket
has 31 lines of code (exceeds 25 allowed). Consider refactoring. Open
checkStatusSocket: function () {
if ( window.socket ) {
return;
}
Function addTask
has 30 lines of code (exceeds 25 allowed). Consider refactoring. Open
addTask: function ( taskdata ) {
if ( !$addTaskDialog ) {
$addTaskDialog = $( '<div>' )
.html( nunjucksEnv.render( 'addTask.html' ) );
FIXME found Open
newTaskData.uploadedFile = {}; // FIXME
- Exclude checks
FIXME found Open
// data.uploadedBytes = data.result.offset; // FIXME: Doesn't work, so we have to abort it
- Exclude checks
Similar blocks of code found in 2 locations. Consider refactoring. Open
if ( !newTaskData.filedescchecked || filedesc !== newTaskData.filedesc ) {
return video2commons.askAPI( 'validatefiledesc', {
filedesc: filedesc
}, [ 'filedesc' ] )
.done( function () {
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 77.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
if ( !newTaskData.filenamechecked || filename !== newTaskData.filename ) {
return video2commons.askAPI( 'validatefilename', {
filename: filename
}, [ 'filename' ] )
.done( function () {
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 77.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Identical blocks of code found in 2 locations. Consider refactoring. Open
video2commons.apiPost( 'task/run', newTaskData )
.done( function ( data ) {
if ( data.error ) {
// eslint-disable-next-line no-alert
window.alert( data.error );
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 46.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Identical blocks of code found in 2 locations. Consider refactoring. Open
video2commons.apiPost( 'task/' + eventName, {
id: video2commons.getTaskIDFromDOMID( $obj.attr( 'id' ) )
} )
.done( function ( data ) {
if ( data.error ) {
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 46.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76