Toollabs/video2commons

View on GitHub
video2commons/frontend/static/video2commons.js

Summary

Maintainability
F
4 days
Test Coverage

File video2commons.js has 821 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/* globals nunjucks: false, io: false, Qs: false */
( function ( $ ) {
    'use strict';

    var config = window.config,
Severity: Major
Found in video2commons/frontend/static/video2commons.js - About 1 day to fix

    Function processInput has 100 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            processInput: function ( button ) {
                var resolved = $.when(); // A resolved jQuery promise
    
                var deferred;
                switch ( newTaskData.step ) {
    Severity: Major
    Found in video2commons/frontend/static/video2commons.js - About 4 hrs to fix

      Function updateTask has 71 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              updateTask: function ( val ) {
                  var table = $( '#tasktable > tbody' );
      
                  var id = 'task-' + val.id,
                      $row = $( '#' + id );
      Severity: Major
      Found in video2commons/frontend/static/video2commons.js - About 2 hrs to fix

        Function setupAddTaskDialog has 63 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                setupAddTaskDialog: function () {
                    switch ( newTaskData.step ) {
                        case 'source':
                            $addTaskDialog.find( '.modal-body' )
                                .html( nunjucksEnv.render( 'sourceForm.html' ) );
        Severity: Major
        Found in video2commons/frontend/static/video2commons.js - About 2 hrs to fix

          Function initUpload has 61 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  initUpload: function () {
                      var deferred;
          
                      window.jqXHR = $addTaskDialog.find( '#fileupload' ).fileupload( {
                          dataType: 'json',
          Severity: Major
          Found in video2commons/frontend/static/video2commons.js - About 2 hrs to fix

            Function setupTaskRow has 54 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                    setupTaskRow: function ( $row, id, status ) {
                        switch ( status ) {
                            case 'progress':
                                /* eslint-disable indent */
                                $row.append( $( '<td />' )
            Severity: Major
            Found in video2commons/frontend/static/video2commons.js - About 2 hrs to fix

              Function reactivatePrevNextButtons has 39 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                      reactivatePrevNextButtons: function () {
                          $addTaskDialog.find( '#dialog-spinner' )
                              .hide();
                          switch ( newTaskData.step ) {
                              case 'source':
              Severity: Minor
              Found in video2commons/frontend/static/video2commons.js - About 1 hr to fix

                Function checkStatusSocket has 31 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                        checkStatusSocket: function () {
                            if ( window.socket ) {
                                return;
                            }
                
                
                Severity: Minor
                Found in video2commons/frontend/static/video2commons.js - About 1 hr to fix

                  Function addTask has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                          addTask: function ( taskdata ) {
                              if ( !$addTaskDialog ) {
                                  $addTaskDialog = $( '<div>' )
                                      .html( nunjucksEnv.render( 'addTask.html' ) );
                  
                  
                  Severity: Minor
                  Found in video2commons/frontend/static/video2commons.js - About 1 hr to fix

                    FIXME found
                    Open

                                                newTaskData.uploadedFile = {}; // FIXME

                    FIXME found
                    Open

                                                // data.uploadedBytes = data.result.offset; // FIXME: Doesn't work, so we have to abort it

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                                                if ( !newTaskData.filedescchecked || filedesc !== newTaskData.filedesc ) {
                                                    return video2commons.askAPI( 'validatefiledesc', {
                                                        filedesc: filedesc
                                                    }, [ 'filedesc' ] )
                                                        .done( function () {
                    Severity: Major
                    Found in video2commons/frontend/static/video2commons.js and 1 other location - About 2 hrs to fix
                    video2commons/frontend/static/video2commons.js on lines 755..764

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 77.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                                                if ( !newTaskData.filenamechecked || filename !== newTaskData.filename ) {
                                                    return video2commons.askAPI( 'validatefilename', {
                                                        filename: filename
                                                    }, [ 'filename' ] )
                                                        .done( function () {
                    Severity: Major
                    Found in video2commons/frontend/static/video2commons.js and 1 other location - About 2 hrs to fix
                    video2commons/frontend/static/video2commons.js on lines 775..784

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 77.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                                                video2commons.apiPost( 'task/run', newTaskData )
                                                    .done( function ( data ) {
                                                        if ( data.error ) {
                                                            // eslint-disable-next-line no-alert
                                                            window.alert( data.error );
                    Severity: Minor
                    Found in video2commons/frontend/static/video2commons.js and 1 other location - About 35 mins to fix
                    video2commons/frontend/static/video2commons.js on lines 412..421

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 46.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                                video2commons.apiPost( 'task/' + eventName, {
                                    id: video2commons.getTaskIDFromDOMID( $obj.attr( 'id' ) )
                                } )
                                    .done( function ( data ) {
                                        if ( data.error ) {
                    Severity: Minor
                    Found in video2commons/frontend/static/video2commons.js and 1 other location - About 35 mins to fix
                    video2commons/frontend/static/video2commons.js on lines 657..664

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 46.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status