TrestleAdmin/trestle

View on GitHub

Showing 38 of 69 total issues

Method initialize has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
Open

      def initialize(admin, options={})
        super(options) do |instance|
          admin.default_form_attributes.each do |attribute|
            if attribute.array?
              if [:string, :text].include?(attribute.type)
Severity: Minor
Found in lib/trestle/form/automatic.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method autoformat_value has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

    def autoformat_value(value, **options)
      case value
      when Array
        tag.ol(safe_join(value.map { |v|
          tag.li(v.is_a?(Array) ? v : autoformat_value(v, **options)) },
Severity: Minor
Found in app/helpers/trestle/format_helper.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method destroy has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

        def destroy
          if delete_instance
            respond_to do |format|
              flash[:message] = flash_message("destroy.success", title: "Success!", message: "The %{lowercase_model_name} was successfully deleted.")

Severity: Minor
Found in app/controllers/concerns/trestle/resource/controller/actions.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method create has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

        def create
          if save_instance
            respond_to do |format|
              flash[:message] = flash_message("create.success", title: "Success!", message: "The %{lowercase_model_name} was successfully created.")

Severity: Minor
Found in app/controllers/concerns/trestle/resource/controller/actions.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method column_value has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

        def column_value(instance)
          if @column.block
            if block_is_legacy_haml?
              # In order for table column blocks to work properly within Haml templates,
              # the _hamlout local variable needs to be defined in the scope of the block,
Severity: Minor
Found in lib/trestle/table/column.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method initialize has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def initialize(admin, options={})
        super(options) do |instance|
          admin.default_form_attributes.each do |attribute|
            if attribute.array?
              if [:string, :text].include?(attribute.type)
Severity: Minor
Found in lib/trestle/form/automatic.rb - About 1 hr to fix

    Method show has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

            def show
              if admin.singular? && instance.nil?
                respond_to do |format|
                  format.html { redirect_to action: :new }
                  format.json { head :not_found }
    Severity: Minor
    Found in app/controllers/concerns/trestle/resource/controller/actions.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method edit has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

            def edit
              if admin.singular? && instance.nil?
                respond_to do |format|
                  format.html { redirect_to action: :new }
                  format.json { head :not_found }
    Severity: Minor
    Found in app/controllers/concerns/trestle/resource/controller/actions.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method admin_link_to has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        def admin_link_to(content=nil, instance=nil, admin: nil, action: nil, method: nil, params: {}, **options, &block)
          # Block given - ignore content parameter and capture content from block
          if block_given?
            instance, content = content, capture(&block)
          end
    Severity: Minor
    Found in app/helpers/trestle/url_helper.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method hsl has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        def hsl
          r = @r / 255.0
          g = @g / 255.0
          b = @b / 255.0
    
    
    Severity: Minor
    Found in lib/trestle/color.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method autoformat_value has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def autoformat_value(value, **options)
          case value
          when Array
            tag.ol(safe_join(value.map { |v|
              tag.li(v.is_a?(Array) ? v : autoformat_value(v, **options)) },
    Severity: Minor
    Found in app/helpers/trestle/format_helper.rb - About 1 hr to fix

      Method default_attributes has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

            def default_attributes
              model.columns.map do |column|
                if column.name.end_with?("_id") && (name = column.name.sub(/_id$/, '')) && (reflection = model.reflections[name])
                  Attribute::Association.new(column.name, class: -> { reflection.klass }, name: name, polymorphic: reflection.polymorphic?, type_column: reflection.foreign_type)
                elsif column.name.end_with?("_type") && (name = column.name.sub(/_type$/, '')) && (reflection = model.reflections[name])
      Severity: Minor
      Found in lib/trestle/adapters/active_record_adapter.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method render has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

              def render
                tag.div(**options.except(*WRAPPER_OPTIONS)) do
                  concat label if name && options[:label] != false
                  concat template.capture(&block) if block
                  concat help_message if options[:help]
      Severity: Minor
      Found in lib/trestle/form/fields/form_group.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function _rgbToHsl has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        _rgbToHsl (r, g, b) {
          r /= 255
          g /= 255
          b /= 255
      
      

        Method table has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

            def table(name=nil, collection: nil, **options, &block)
              if block_given?
                table = Table::Builder.build(**options, &block)
              else
                if name.is_a?(Trestle::Table)
        Severity: Minor
        Found in app/helpers/trestle/table_helper.rb - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method input_group has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

                def input_group
                  if @prepend || @append
                    tag.div(class: "input-group") do
                      concat input_group_addon(@prepend) if @prepend
                      concat yield
        Severity: Minor
        Found in lib/trestle/form/fields/form_control.rb - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method render? has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

                def render?
                  if options.key?(:if)
                    if options[:if].respond_to?(:call)
                      @template.instance_exec(&options[:if])
                    else
        Severity: Minor
        Found in lib/trestle/table/column.rb - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method content_columns has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

              def content_columns
                admin.default_table_attributes.map.with_index do |attribute, index|
                  case attribute.type
                  when :association
                    Column.new(attribute.association_name, sort: false)
        Severity: Minor
        Found in lib/trestle/table/automatic.rb - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method initialize has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                def initialize(builder, template, name, value=nil, options={}, &block)
        Severity: Minor
        Found in lib/trestle/form/fields/static_field.rb - About 45 mins to fix

          Method method_missing has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

                def method_missing(name, *args, &block)
                  target = @form.respond_to?(name) ? @form : @template
          
                  if block_given? && !RAW_BLOCK_HELPERS.include?(name)
                    result = target.send(name, *args) do |*blockargs|
          Severity: Minor
          Found in lib/trestle/form/renderer.rb - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language