Sign upLogin

TryGhost/Ghost

View on GitHub
Star
ghost/admin/app/components/dashboard/charts/anchor-attribution.js

Summary

Maintainability
F
6 days
Test Coverage

Function emptyData has 368 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    get emptyData() {
        return {
            stats: [
                {
                    date: '2022-04-07',
Severity: Major
Found in ghost/admin/app/components/dashboard/charts/anchor-attribution.js - About 1 day to fix

    File anchor-attribution.js has 740 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /* global Chart */

import Component from '@glimmer/component';
import moment from 'moment-timezone';
import {action} from '@ember/object';
    Severity: Major
    Found in ghost/admin/app/components/dashboard/charts/anchor-attribution.js - About 1 day to fix

      Function chartOptions has 125 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          get chartOptions() {
        const that = this;
        let activeDays = this.dashboardStats.chartDays;
        let barColor = this.feature.nightShift ? 'rgba(200, 204, 217, 0.25)' : 'rgba(200, 204, 217, 0.65)';
      Severity: Major
      Found in ghost/admin/app/components/dashboard/charts/anchor-attribution.js - About 5 hrs to fix

        Function chartOptions has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
        Open

            get chartOptions() {
        const that = this;
        let activeDays = this.dashboardStats.chartDays;
        let barColor = this.feature.nightShift ? 'rgba(200, 204, 217, 0.25)' : 'rgba(200, 204, 217, 0.65)';
        Severity: Minor
        Found in ghost/admin/app/components/dashboard/charts/anchor-attribution.js - About 3 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Anchor has 29 functions (exceeds 20 allowed). Consider refactoring.
        Open

        export default class Anchor extends Component {
    @service dashboardStats;
    @service feature;
    @tracked chartDisplay = 'mrr';
    @tracked resizing = false;
        Severity: Minor
        Found in ghost/admin/app/components/dashboard/charts/anchor-attribution.js - About 3 hrs to fix

          Function chartData has 55 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              get chartData() {
        let stats;
        let labels;
        let data;
          Severity: Major
          Found in ghost/admin/app/components/dashboard/charts/anchor-attribution.js - About 2 hrs to fix

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                get paidMembersTrend() {
        if (this.dashboardStats.memberCountsTrend) {
            return this.calculatePercentage(this.dashboardStats.memberCountsTrend.paid, this.dashboardStats.memberCounts.paid);
        }
        return 0;
            Severity: Major
            Found in ghost/admin/app/components/dashboard/charts/anchor-attribution.js and 2 other locations - About 1 hr to fix
            ghost/admin/app/components/dashboard/charts/anchor-attribution.js on lines 158..163
            ghost/admin/app/components/dashboard/charts/anchor-attribution.js on lines 172..177

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 62.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                get totalMembersTrend() {
        if (this.dashboardStats.memberCountsTrend) {
            return this.calculatePercentage(this.dashboardStats.memberCountsTrend.total, this.dashboardStats.memberCounts.total);
        }
        return 0;
            Severity: Major
            Found in ghost/admin/app/components/dashboard/charts/anchor-attribution.js and 2 other locations - About 1 hr to fix
            ghost/admin/app/components/dashboard/charts/anchor-attribution.js on lines 165..170
            ghost/admin/app/components/dashboard/charts/anchor-attribution.js on lines 172..177

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 62.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                get freeMembersTrend() {
        if (this.dashboardStats.memberCountsTrend) {
            return this.calculatePercentage(this.dashboardStats.memberCountsTrend.free, this.dashboardStats.memberCounts.free);
        }
        return 0;
            Severity: Major
            Found in ghost/admin/app/components/dashboard/charts/anchor-attribution.js and 2 other locations - About 1 hr to fix
            ghost/admin/app/components/dashboard/charts/anchor-attribution.js on lines 158..163
            ghost/admin/app/components/dashboard/charts/anchor-attribution.js on lines 165..170

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 62.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                calculatePercentage(from, to) {
        if (from === 0) {
            if (to > 0) {
                return 100;
            }
            Severity: Major
            Found in ghost/admin/app/components/dashboard/charts/anchor-attribution.js and 1 other location - About 1 hr to fix
            ghost/admin/app/components/dashboard/charts/overview.js on lines 78..87

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 61.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            const DISPLAY_OPTIONS = [{
    name: 'MRR',
    value: 'mrr'
},{
    name: 'Total members',
            Severity: Major
            Found in ghost/admin/app/components/dashboard/charts/anchor-attribution.js and 1 other location - About 1 hr to fix
            ghost/admin/app/components/members/filters/relation-options/date.js on lines 1..6

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 55.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                                gridLines: {
                        color: barColor,
                        borderDash: [3,4],
                        display: true,
                        drawBorder: true,
            Severity: Minor
            Found in ghost/admin/app/components/dashboard/charts/anchor-attribution.js and 1 other location - About 50 mins to fix
            ghost/admin/app/components/dashboard/charts/paid-breakdown.js on lines 327..336

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 52.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                                    if (this.selectedChartDisplay === 'mrr') {
                            const value = moment(tooltipItems[0].xLabel).format(DATE_FORMAT);
                            document.querySelector('#gh-dashboard-anchor-tooltip .gh-dashboard-tooltip-label').innerHTML = value;
                        } else {
            Severity: Major
            Found in ghost/admin/app/components/dashboard/charts/anchor-attribution.js and 2 other locations - About 40 mins to fix
            ghost/admin/app/components/dashboard/charts/anchor-attribution.js on lines 358..361
            ghost/admin/app/components/dashboard/charts/paid-breakdown.js on lines 299..302

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 49.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                                    } else {
                            const value = moment(tooltipItems[0].xLabel).format(DATE_FORMAT);
                            document.querySelector('#gh-dashboard-anchor-tooltip .gh-dashboard-tooltip-label').innerHTML = value;
                        }
            Severity: Major
            Found in ghost/admin/app/components/dashboard/charts/anchor-attribution.js and 2 other locations - About 40 mins to fix
            ghost/admin/app/components/dashboard/charts/anchor-attribution.js on lines 355..358
            ghost/admin/app/components/dashboard/charts/paid-breakdown.js on lines 299..302

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 49.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status