TryGhost/Ghost

View on GitHub
ghost/admin/app/components/dashboard/charts/paid-breakdown.js

Summary

Maintainability
D
2 days
Test Coverage

Function chartOptions has 102 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    get chartOptions() {
        const barColor = this.feature.nightShift ? 'rgba(200, 204, 217, 0.25)' : 'rgba(200, 204, 217, 0.65)';

        return {
            responsive: true,
Severity: Major
Found in ghost/admin/app/components/dashboard/charts/paid-breakdown.js - About 4 hrs to fix

    Function draw has 92 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        draw: function () {
            var ctx = this._chart.ctx;
            var vm = this._view;
            var left, right, top, bottom, borderSkipped, radius;
    
    
    Severity: Major
    Found in ghost/admin/app/components/dashboard/charts/paid-breakdown.js - About 3 hrs to fix

      File paid-breakdown.js has 274 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      /* globals Chart */
      
      import Component from '@glimmer/component';
      import moment from 'moment-timezone';
      import {action} from '@ember/object';
      Severity: Minor
      Found in ghost/admin/app/components/dashboard/charts/paid-breakdown.js - About 2 hrs to fix

        Function draw has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
        Open

            draw: function () {
                var ctx = this._chart.ctx;
                var vm = this._view;
                var left, right, top, bottom, borderSkipped, radius;
        
        
        Severity: Minor
        Found in ghost/admin/app/components/dashboard/charts/paid-breakdown.js - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function chartData has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            get chartData() {
                const stats = this.dashboardStats.filledSubscriptionCountStats;
                const labels = stats.map(stat => stat.date);
                const newData = stats.map(stat => stat.signups || 0);
                const canceledData = stats.map(stat => -(stat.cancellations || 0));
        Severity: Minor
        Found in ghost/admin/app/components/dashboard/charts/paid-breakdown.js - About 1 hr to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                      if (radius > Math.abs(height) / 2) {
                          radius = Math.floor(Math.abs(height) / 2);
                      }
          Severity: Minor
          Found in ghost/admin/app/components/dashboard/charts/paid-breakdown.js and 1 other location - About 50 mins to fix
          ghost/admin/app/components/dashboard/charts/paid-mix.js on lines 102..104

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 52.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                              gridLines: {
                                  color: barColor,
                                  borderDash: [4,4],
                                  display: false,
                                  drawBorder: false,
          Severity: Minor
          Found in ghost/admin/app/components/dashboard/charts/paid-breakdown.js and 1 other location - About 50 mins to fix
          ghost/admin/app/components/dashboard/charts/anchor-attribution.js on lines 385..394

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 52.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                      if (radius > Math.abs(width) / 2) {
                          radius = Math.floor(Math.abs(width) / 2);
                      }
          Severity: Minor
          Found in ghost/admin/app/components/dashboard/charts/paid-breakdown.js and 1 other location - About 45 mins to fix
          ghost/admin/app/components/dashboard/charts/paid-mix.js on lines 105..107

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 50.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                              title: (tooltipItems) => {
                                  const value = moment(tooltipItems[0].xLabel).format(DATE_FORMAT);
                                  document.querySelector('#gh-dashboard-breakdown-tooltip .gh-dashboard-tooltip-label').innerHTML = value;
                              }
          Severity: Major
          Found in ghost/admin/app/components/dashboard/charts/paid-breakdown.js and 2 other locations - About 40 mins to fix
          ghost/admin/app/components/dashboard/charts/anchor-attribution.js on lines 355..358
          ghost/admin/app/components/dashboard/charts/anchor-attribution.js on lines 358..361

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 49.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status