TryGhost/Ghost

View on GitHub
ghost/admin/app/helpers/parse-member-event.js

Summary

Maintainability
F
4 days
Test Coverage

Function getAction has a Cognitive Complexity of 37 (exceeds 5 allowed). Consider refactoring.
Open

    getAction(event, hasMultipleNewsletters) {
        if (event.type === 'signup_event' || (event.type === 'subscription_event' && event.data.type === 'created' && event.data.signup)) {
            return 'signed up';
        }

Severity: Minor
Found in ghost/admin/app/helpers/parse-member-event.js - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getIcon has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
Open

    getIcon(event) {
        let icon;

        if (event.type === 'login_event') {
            icon = 'logged-in';
Severity: Minor
Found in ghost/admin/app/helpers/parse-member-event.js - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getAction has 77 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    getAction(event, hasMultipleNewsletters) {
        if (event.type === 'signup_event' || (event.type === 'subscription_event' && event.data.type === 'created' && event.data.signup)) {
            return 'signed up';
        }

Severity: Major
Found in ghost/admin/app/helpers/parse-member-event.js - About 3 hrs to fix

    File parse-member-event.js has 273 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import Helper from '@ember/component/helper';
    import moment from 'moment-timezone';
    import {getNonDecimal, getSymbol} from 'ghost-admin/utils/currency';
    import {ghPluralize} from 'ghost-admin/helpers/gh-pluralize';
    import {inject as service} from '@ember/service';
    Severity: Minor
    Found in ghost/admin/app/helpers/parse-member-event.js - About 2 hrs to fix

      Function getIcon has 55 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          getIcon(event) {
              let icon;
      
              if (event.type === 'login_event') {
                  icon = 'logged-in';
      Severity: Major
      Found in ghost/admin/app/helpers/parse-member-event.js - About 2 hrs to fix

        Function getInfo has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
        Open

            getInfo(event) {
                if (event.type === 'subscription_event') {
                    let mrrDelta = getNonDecimal(event.data.mrr_delta, event.data.currency);
                    if (mrrDelta === 0) {
                        return;
        Severity: Minor
        Found in ghost/admin/app/helpers/parse-member-event.js - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function compute has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            compute([event, hasMultipleNewsletters]) {
                const subject = event.data.member ? (event.data.member.name || event.data.member.email) : (event.data.name || event.data.email || '');
                const icon = this.getIcon(event);
                const action = this.getAction(event, hasMultipleNewsletters);
                const info = this.getInfo(event);
        Severity: Minor
        Found in ghost/admin/app/helpers/parse-member-event.js - About 1 hr to fix

          Function getObject has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

              getObject(event) {
                  if (event.type === 'signup_event' || event.type === 'subscription_event' || event.type === 'donation_event') {
                      if (event.data.attribution?.title) {
                          return event.data.attribution.title;
                      }
          Severity: Minor
          Found in ghost/admin/app/helpers/parse-member-event.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid too many return statements within this function.
          Open

                      return 'email flagged as spam';
          Severity: Major
          Found in ghost/admin/app/helpers/parse-member-event.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                        return 'commented';
            Severity: Major
            Found in ghost/admin/app/helpers/parse-member-event.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                          return 'clicked link in email';
              Severity: Major
              Found in ghost/admin/app/helpers/parse-member-event.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                            return 'less like this';
                Severity: Major
                Found in ghost/admin/app/helpers/parse-member-event.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                              return `Made a one-time payment`;
                  Severity: Major
                  Found in ghost/admin/app/helpers/parse-member-event.js - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                                    return 'clicked link in email';
                    Severity: Major
                    Found in ghost/admin/app/helpers/parse-member-event.js - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                                      return 'reactivated paid subscription';
                      Severity: Major
                      Found in ghost/admin/app/helpers/parse-member-event.js - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                                        return 'ended paid subscription';
                        Severity: Major
                        Found in ghost/admin/app/helpers/parse-member-event.js - About 30 mins to fix

                          Avoid too many return statements within this function.
                          Open

                                      return 'received email';
                          Severity: Major
                          Found in ghost/admin/app/helpers/parse-member-event.js - About 30 mins to fix

                            Avoid too many return statements within this function.
                            Open

                                    return;
                            Severity: Major
                            Found in ghost/admin/app/helpers/parse-member-event.js - About 30 mins to fix

                              Avoid too many return statements within this function.
                              Open

                                              return 'started paid subscription';
                              Severity: Major
                              Found in ghost/admin/app/helpers/parse-member-event.js - About 30 mins to fix

                                Avoid too many return statements within this function.
                                Open

                                                return 'canceled paid subscription';
                                Severity: Major
                                Found in ghost/admin/app/helpers/parse-member-event.js - About 30 mins to fix

                                  Avoid too many return statements within this function.
                                  Open

                                              return `clicked ${ghPluralize(event.data.count.clicks, 'link')} in email`;
                                  Severity: Major
                                  Found in ghost/admin/app/helpers/parse-member-event.js - About 30 mins to fix

                                    Avoid too many return statements within this function.
                                    Open

                                                    return 'more like this';
                                    Severity: Major
                                    Found in ghost/admin/app/helpers/parse-member-event.js - About 30 mins to fix

                                      Avoid too many return statements within this function.
                                      Open

                                                      return 'unsubscribed from ' + newsletter;
                                      Severity: Major
                                      Found in ghost/admin/app/helpers/parse-member-event.js - About 30 mins to fix

                                        Avoid too many return statements within this function.
                                        Open

                                                        return 'changed paid subscription';
                                        Severity: Major
                                        Found in ghost/admin/app/helpers/parse-member-event.js - About 30 mins to fix

                                          Avoid too many return statements within this function.
                                          Open

                                                      return 'opened email';
                                          Severity: Major
                                          Found in ghost/admin/app/helpers/parse-member-event.js - About 30 mins to fix

                                            Avoid too many return statements within this function.
                                            Open

                                                        return 'sent email';
                                            Severity: Major
                                            Found in ghost/admin/app/helpers/parse-member-event.js - About 30 mins to fix

                                              Avoid too many return statements within this function.
                                              Open

                                                          return 'changed paid subscription';
                                              Severity: Major
                                              Found in ghost/admin/app/helpers/parse-member-event.js - About 30 mins to fix

                                                Avoid too many return statements within this function.
                                                Open

                                                            return 'bounced email';
                                                Severity: Major
                                                Found in ghost/admin/app/helpers/parse-member-event.js - About 30 mins to fix

                                                  Avoid too many return statements within this function.
                                                  Open

                                                                  return 'replied to comment';
                                                  Severity: Major
                                                  Found in ghost/admin/app/helpers/parse-member-event.js - About 30 mins to fix

                                                    Avoid too many return statements within this function.
                                                    Open

                                                                return formattedAmount;
                                                    Severity: Major
                                                    Found in ghost/admin/app/helpers/parse-member-event.js - About 30 mins to fix

                                                      Function getURL has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                                                      Open

                                                          getURL(event) {
                                                              if (['comment_event', 'click_event', 'feedback_event'].includes(event.type)) {
                                                                  if (event.data.post) {
                                                                      return event.data.post.url;
                                                                  }
                                                      Severity: Minor
                                                      Found in ghost/admin/app/helpers/parse-member-event.js - About 25 mins to fix

                                                      Cognitive Complexity

                                                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                                      A method's cognitive complexity is based on a few simple rules:

                                                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                                      • Code is considered more complex for each "break in the linear flow of the code"
                                                      • Code is considered more complex when "flow breaking structures are nested"

                                                      Further reading

                                                      Function getRoute has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                                                      Open

                                                          getRoute(event) {
                                                              if (['comment_event', 'click_event', 'feedback_event'].includes(event.type)) {
                                                                  if (event.data.post) {
                                                                      return {
                                                                          name: 'posts.analytics',
                                                      Severity: Minor
                                                      Found in ghost/admin/app/helpers/parse-member-event.js - About 25 mins to fix

                                                      Cognitive Complexity

                                                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                                      A method's cognitive complexity is based on a few simple rules:

                                                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                                      • Code is considered more complex for each "break in the linear flow of the code"
                                                      • Code is considered more complex when "flow breaking structures are nested"

                                                      Further reading

                                                      Similar blocks of code found in 2 locations. Consider refactoring.
                                                      Open

                                                              if (event.type === 'signup_event' || (event.type === 'subscription_event' && event.data.type === 'created' && event.data.signup)) {
                                                                  return 'signed up';
                                                              }
                                                      Severity: Minor
                                                      Found in ghost/admin/app/helpers/parse-member-event.js and 1 other location - About 45 mins to fix
                                                      ghost/admin/app/helpers/parse-member-event.js on lines 73..75

                                                      Duplicated Code

                                                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                                      Tuning

                                                      This issue has a mass of 50.

                                                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                                      Refactorings

                                                      Further Reading

                                                      Similar blocks of code found in 2 locations. Consider refactoring.
                                                      Open

                                                              if (event.type === 'signup_event' || (event.type === 'subscription_event' && event.data.type === 'created' && event.data.signup)) {
                                                                  icon = 'signed-up';
                                                              }
                                                      Severity: Minor
                                                      Found in ghost/admin/app/helpers/parse-member-event.js and 1 other location - About 45 mins to fix
                                                      ghost/admin/app/helpers/parse-member-event.js on lines 121..123

                                                      Duplicated Code

                                                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                                      Tuning

                                                      This issue has a mass of 50.

                                                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                                      Refactorings

                                                      Further Reading

                                                      There are no issues that match your filters.

                                                      Category
                                                      Status