Sign upLogin

TryGhost/Ghost

View on GitHub
Star
ghost/admin/app/validators/mixins/password.js

Summary

Maintainability
A
3 hrs
Test Coverage

Function passwordValidation has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    passwordValidation(model, password, errorTarget) {
        let blogUrl = model.config?.blogUrl || window.location.host;
        let blogTitle = model.blogTitle || model.config?.blogTitle;
        let blogUrlWithSlash;
Severity: Minor
Found in ghost/admin/app/validators/mixins/password.js - About 1 hr to fix

    Function passwordValidation has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        passwordValidation(model, password, errorTarget) {
        let blogUrl = model.config?.blogUrl || window.location.host;
        let blogTitle = model.blogTitle || model.config?.blogTitle;
        let blogUrlWithSlash;
    Severity: Minor
    Found in ghost/admin/app/validators/mixins/password.js - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _characterOccurance has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        _characterOccurance(stringToTest) {
        let chars = {};
        let allowedOccurancy;
        let valid = true;
    Severity: Minor
    Found in ghost/admin/app/validators/mixins/password.js - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status