Sign upLogin

TryGhost/Ghost

View on GitHub
Star
ghost/api-framework/lib/pipeline.js

Summary

Maintainability
C
1 day
Test Coverage

Function pipeline has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
Open

const pipeline = (apiController, apiUtils, apiType) => {
    if (controllerMap.has(apiController)) {
        return controllerMap.get(apiController);
    }
Severity: Minor
Found in ghost/api-framework/lib/pipeline.js - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function pipeline has 72 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const pipeline = (apiController, apiUtils, apiType) => {
    if (controllerMap.has(apiController)) {
        return controllerMap.get(apiController);
    }
Severity: Major
Found in ghost/api-framework/lib/pipeline.js - About 2 hrs to fix

    Function result has 63 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        const result = keys.reduce((obj, method) => {
        const apiImpl = _.cloneDeep(apiController)[method];

        Object.freeze(apiImpl.headers);
    Severity: Major
    Found in ghost/api-framework/lib/pipeline.js - About 2 hrs to fix

      Function ImplWrapper has 57 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              obj[method] = async function ImplWrapper() {
            const apiConfig = {docName, method};
            let options;
            let data;
            let frame;
      Severity: Major
      Found in ghost/api-framework/lib/pipeline.js - About 2 hrs to fix

        Function output has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                output(response, apiUtils, apiConfig, apiImpl, frame) {
        Severity: Minor
        Found in ghost/api-framework/lib/pipeline.js - About 35 mins to fix

          There are no issues that match your filters.

          Category
          Status