Sign upLogin

TryGhost/Ghost

View on GitHub
Star
ghost/core/core/boot.js

Summary

Maintainability
C
1 day
Test Coverage

File boot.js has 398 lines of code (exceeds 250 allowed). Consider refactoring.
Open

// The Ghost Boot Sequence
// -----------------------
// - This is intentionally one big file at the moment, so that we don't have to follow boot logic all over the place
// - This file is FULL of debug statements so we can see timings for the various steps because the boot needs to be as fast as possible
// - As we manage to break the codebase down into distinct components for e.g. the frontend, their boot logic can be offloaded to them
Severity: Minor
Found in ghost/core/core/boot.js - About 5 hrs to fix

    Function initServices has 73 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    async function initServices() {
    debug('Begin: initServices');

    debug('Begin: Services');
    const stripe = require('./server/services/stripe');
    Severity: Major
    Found in ghost/core/core/boot.js - About 2 hrs to fix

      Function bootGhost has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

      async function bootGhost({backend = true, frontend = true, server = true} = {}) {
    // Metrics
    const startTime = Date.now();
    debug('Begin Boot');
      Severity: Minor
      Found in ghost/core/core/boot.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function initNestDependencies has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      async function initNestDependencies() {
    debug('Begin: initNestDependencies');
    const GhostNestApp = require('@tryghost/ghost');
    const providers = [];
    const urlUtils = require('./shared/url-utils');
      Severity: Minor
      Found in ghost/core/core/boot.js - About 1 hr to fix

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

                if (!errors.utils.isGhostError(serverStartError)) {
            serverStartError = new errors.InternalServerError({message: serverStartError.message, err: serverStartError});
        }
        Severity: Major
        Found in ghost/core/core/boot.js and 2 other locations - About 50 mins to fix
        ghost/core/core/server/data/db/DatabaseStateManager.js on lines 63..65
        ghost/core/core/server/data/db/DatabaseStateManager.js on lines 94..96

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 51.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status