TryGhost/Ghost

View on GitHub
ghost/core/core/server/models/base/plugins/raw-knex.js

Summary

Maintainability
D
1 day
Test Coverage

Function exports has 154 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function (Bookshelf) {
    Bookshelf.Model = Bookshelf.Model.extend({}, {
        /**
         * If you want to fetch all data fast, i recommend using this function.
         * Bookshelf is just too slow, too much ORM overhead.
Severity: Major
Found in ghost/core/core/server/models/base/plugins/raw-knex.js - About 6 hrs to fix

    Function fetchAll has 148 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

                fetchAll: function (options) {
                    options = options || {};
    
                    const nql = require('@tryghost/nql');
                    const modelName = options.modelName;
    Severity: Major
    Found in ghost/core/core/server/models/base/plugins/raw-knex.js - About 5 hrs to fix

      Function exports has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

      module.exports = function (Bookshelf) {
          Bookshelf.Model = Bookshelf.Model.extend({}, {
              /**
               * If you want to fetch all data fast, i recommend using this function.
               * Bookshelf is just too slow, too much ORM overhead.
      Severity: Minor
      Found in ghost/core/core/server/models/base/plugins/raw-knex.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status