Sign upLogin

TryGhost/Ghost

View on GitHub
Star
ghost/core/core/server/services/permissions/can-this.js

Summary

Maintainability
B
6 hrs
Test Coverage

Function buildObjectTypeHandlers has 62 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    buildObjectTypeHandlers(objTypes, actType, context, permissionLoad) {
        const objectTypeModelMap = {
            post: models.Post,
            role: models.Role,
            user: models.User,
Severity: Major
Found in ghost/core/core/server/services/permissions/can-this.js - About 2 hrs to fix

    Function objType has 46 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

                objTypeHandlers[objType] = function (modelOrId, unsafeAttrs) {
                let modelId;
                unsafeAttrs = unsafeAttrs || {};

                // If it's an internal request, resolve immediately
    Severity: Minor
    Found in ghost/core/core/server/services/permissions/can-this.js - About 1 hr to fix

      Function beginCheck has 39 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          beginCheck(context) {
        const self = this;
        let userPermissionLoad;
        let apiKeyPermissionLoad;
        let memberPermissionLoad;
      Severity: Minor
      Found in ghost/core/core/server/services/permissions/can-this.js - About 1 hr to fix

        Function beginCheck has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            beginCheck(context) {
        const self = this;
        let userPermissionLoad;
        let apiKeyPermissionLoad;
        let memberPermissionLoad;
        Severity: Minor
        Found in ghost/core/core/server/services/permissions/can-this.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status